webhook timeout variable #1387
Merged
webhook timeout variable #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, can we set the default timeout value to |
liyinan926
reviewed
Nov 12, 2021
pkg/webhook/webhook.go
Outdated
| @@ -86,6 +86,7 @@ type WebHook struct { | |||
| enableResourceQuotaEnforcement bool | |||
| resourceQuotaEnforcer resourceusage.ResourceQuotaEnforcer | |||
| coreV1InformerFactory informers.SharedInformerFactory | |||
| TimeoutSeconds *int32 | |||
There was a problem hiding this comment.
Nit: timeoutSeconds since it doesn't need to be exposed outside the package.
There was a problem hiding this comment.
Renamed the variable to be timeoutSeconds and also bumped the chart version to have the intermediate fix
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
* Added webhook timeout variable * made timeout variable to be private * Fixed chart version Co-authored-by: Sairaman Kumar <sairamank@in.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webhook timeout by default is set to 30s (as we use AdmissionregistrationV1beta1) and sometimes that causes the request to fail when the number of pods in the cluster is huge. We fix the webhook error by recreating the webhook manually with a lower timeout value (This does get modified when the operator pod restarts).
We found kubernetes/kubernetes#71508, which talks about how the default client timeout is 30s, so if the webhooks have a timeout equal or greater, the client can give up before the apiserver has, which means the failurePolicy: ignore has no effect.
This PR provides a way to set a default value for webhook timeout which allow the users to configure the timeout time based on their usage.