Add docker build to github action #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomHellier
force-pushed
the
test-build-docker-in-github-action
branch
23 times, most recently
from
0e486ce
to
3885130
Compare
Add a docker build into the github CI, even if we don't use it, and also stop using latest as the default container version, as it is clearly wrong, and the latest tag hasn't been updated in a long time. travis-ci.org has stopped building the code for this repository as well, so we should focus on github workflows. Ideally we'd move the building of the docker container into github as well because then at least all CI is managed in one place. Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
force-pushed
the
test-build-docker-in-github-action
branch
from
3885130
to
775d129
Compare
|
It looks like the e2e integration tests are broken, they're expecting files to exist which are not there anymore. I have raised #1416 to address the problem at a later date, and commented out the section of the github action which attempts to run them. |
TomHellier
changed the title
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
Add a docker build into the github CI, even if we don't use it, and also stop using latest as the default container version, as it is clearly wrong, and the latest tag hasn't been updated in a long time. travis-ci.org has stopped building the code for this repository as well, so we should focus on github workflows. Ideally we'd move the building of the docker container into github as well because then at least all CI is managed in one place. Signed-off-by: Tom Hellier <me@tomhellier.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://travis-ci.org stopped building code in June, so this should be removed. Github actions does the same and more anyway.
Adding docker build into github actions, it would be good if this repository could move to use that as its docker container publishing method, as then all CI will be managed by one system.
The helm chart shouldn't default to use the "latest" docker container, as that hasn't been build since May 19th anyway, I've reverted this back to use the chart appVersion (it was using this previously)
Fixes:
#1403
#1372