Fixes an error that was preventing the pods from being mutated #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… internal error because the kind was / instead of AdmissionReview Changed where we set Response
liyinan926
approved these changes
Dec 3, 2021
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
… internal error because the kind was / instead of AdmissionReview (kubeflow#1421) Changed where we set Response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing out the latest changes on k8s 1.22 I noticed that the pods were not getting mutated despite the webhook being invoked.
When I checked the k8s logs I noticed an error message like the following
When I updated the operator to explicitly specify the Kind in TypeMeta the error went away and the modifications were applied to the pod.