Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingress-class-name controller flag #1482

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

voyvodov
Copy link
Contributor

Add a flag to set ingressClassName field for ingress
objects created for Spark UI.
This will make ingress compliant with Kubernetes >v1.19 and
better utilizing multiple ingress controllers

Should fix #1445

@voyvodov voyvodov force-pushed the ingressClassName branch 2 times, most recently from 92462ce to e4565a1 Compare February 16, 2022 15:51
Add a flag to set ingressClassName field for ingress
objects created for Spark UI.
This will make ingress compliant with Kubernetes >v1.19 and
better utilizing multiple ingress controllers
Include ingressClassName changes
@voyvodov
Copy link
Contributor Author

@liyinan926 can I ask you for your check and approval for the workflow?

@liyinan926 liyinan926 merged commit 3b58b26 into kubeflow:master Apr 11, 2022
@voyvodov voyvodov deleted the ingressClassName branch April 11, 2022 17:19
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
* Add ingress-class-name controller flag

Add a flag to set ingressClassName field for ingress
objects created for Spark UI.
This will make ingress compliant with Kubernetes >v1.19 and
better utilizing multiple ingress controllers

* Update Helm chart to v1.1.20/appVersion 1.3.4

Include ingressClassName changes

Co-authored-by: Hristo Voyvodov <hristo.voyvodov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add spec.ingressClassName api
2 participants