fix: fix issue #1723 about spark-operator not working with volcano on OCP

[disaster37]

Fix issue #1723

We fix some parts of code:

• pkg/batchscheduler/volcano/volcano_scheduler.go: to return error when appear on podGroup create.
• pkg/batchscheduler/volcano/volcano_scheduler.go and manifest/spark-operator-install/spark-operator-rbac.yaml to fix right on OCP.

It fix error on OCP

podgroups.scheduling.volcano.sh "spark-spark-test-pg" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , <nil>

[Aakcht]

Hi, @liyinan926 , any chance for reviewing this PR?

[liyinan926]

This change doesn't seem necessary given that pg is not used outside the if-else scope.

[disaster37]

Hum I remeber why I add this. It's because without that, you init new err on if. So on line 154 (inside if)
_, err = v.volcanoClient.SchedulingV1beta1().PodGroups(app.Namespace).Create(context.TODO(), &podGroup, metav1.CreateOptions{})

The err can't be used outside of if / else and so it never returned by

if err != nil {
		return fmt.Errorf("failed to sync PodGroup with error: %s. Abandon schedule pods via volcano", err)
	}

So:

• stay my code like this, or add err handler on if like this

if _, err = v.volcanoClient.SchedulingV1beta1().PodGroups(app.Namespace).Create(context.TODO(), &podGroup, metav1.CreateOptions{}); err != nil {
  return fmt.Errorf("failed to sync PodGroup with error: %s. Abandon schedule pods via volcano", err)
}

[disaster37]

what do you prefer ?

[Aakcht]

@disaster37 @liyinan926 Thanks for taking a look!