Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PVC permission to Operator role #1889

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

wyangsun
Copy link
Contributor

@wyangsun wyangsun commented Dec 11, 2023

Add PVC permission to Operator role, so that Spark Operator able to create Driver pod with PVC by follow spark configs:

    spark.kubernetes.driver.volumes.persistentVolumeClaim.checkpointpvc.options.claimName: "driver"
    spark.kubernetes.driver.volumes.persistentVolumeClaim.checkpointpvc.options.storageClass: "gp2"
    spark.kubernetes.driver.volumes.persistentVolumeClaim.checkpointpvc.options.sizeLimit: "50Gi"
    spark.kubernetes.driver.volumes.persistentVolumeClaim.checkpointpvc.mount.path: "/data"
    spark.kubernetes.driver.volumes.persistentVolumeClaim.checkpointpvc.mount.readOnly: "false"

https://spark.apache.org/docs/latest/running-on-kubernetes.html#using-kubernetes-volumes

Copy link

google-cla bot commented Dec 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@disaster37
Copy link
Contributor

Hi,

any chance to merge it ?

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wyangsun, yuchaoran2011

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuchaoran2011
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Apr 6, 2024
@google-oss-prow google-oss-prow bot merged commit 717a3ec into kubeflow:master Apr 6, 2024
1 of 2 checks passed
peter-mcclonski pushed a commit to TechnologyBrewery/spark-on-k8s-operator that referenced this pull request Apr 16, 2024
Signed-off-by: Peter McClonski <mcclonski_peter@bah.com>
sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants