BUGFIX: Added cancel method to fix context leak #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fazledyn-or <ataf@openrefactory.com>
yuchaoran2011
approved these changes
Apr 6, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fazledyn-or, yuchaoran2011 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
peter-mcclonski
pushed a commit
to TechnologyBrewery/spark-on-k8s-operator
that referenced
this pull request
Apr 16, 2024
Signed-off-by: fazledyn-or <ataf@openrefactory.com> Signed-off-by: Peter McClonski <mcclonski_peter@bah.com>
sigmarkarl
pushed a commit
to spotinst/spark-on-k8s-operator
that referenced
this pull request
Aug 7, 2024
Signed-off-by: fazledyn-or <ataf@openrefactory.com>
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
Signed-off-by: fazledyn-or <ataf@openrefactory.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a context leak bug in your code.
Summary
While triaging your project, our bug fixing tool generated the following message-
Details
In the line below, a context is created using the
WithTimeoutmethod, where the returnedcancelFunchandler is ignored.I have introduced the
cancelhandler and deferred it so that once the methodRun()completes execution, it can be safely cancelled.Sponsorship and Support
This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.
The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.