-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace GoogleCloudPlatform/spark-on-k8s-operator with kubeflow/spark-operator #1937
chore: replace GoogleCloudPlatform/spark-on-k8s-operator with kubeflow/spark-operator #1937
Conversation
@zevisert Could you fix the DCO error as indicated in https://github.com/kubeflow/spark-operator/pull/1937/checks?check_run_id=22904525714? |
df09adb
to
306d4cf
Compare
@yuchaoran2011, my commit message has been amended |
@zevisert Thanks. Please also fix the merge conflicts |
306d4cf
to
3be7a79
Compare
@yuchaoran2011 Done |
Actually, I rebased on master and found one more reference, I need one more commit |
…w/spark-operator Signed-off-by: Zev Isert <dev@zevisert.ca>
3be7a79
to
f408a6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuchaoran2011, zevisert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zevisert Thanks for the PR! I noticed changes to Go files. Could you please confirm if you've had a chance to test those changes? If not, we could create an issue to validate and we can also look at addressing our e2e tests? |
@vara-bonthu No, I tried to make that clear in the description; this was just a find and replace. Were there no tests run as part of this PR? |
…w/spark-operator (kubeflow#1937) Signed-off-by: Zev Isert <dev@zevisert.ca> Signed-off-by: Peter McClonski <mcclonski_peter@bah.com>
This pr breaks all old images pull because in https://github.com/kubeflow/spark-operator/pkgs/container/spark-operator. There is no old version image available at all. Can you revert this pr or copy all image to the new place? Thanks |
Please see the issue here. I don't think I will be the only one who has this issue. |
…w/spark-operator (kubeflow#1937) Signed-off-by: Zev Isert <dev@zevisert.ca>
…w/spark-operator (kubeflow#1937) Signed-off-by: Zev Isert <dev@zevisert.ca>
This is a naïve++ (as in, I did review each change) find and replace of the terms:
GoogleCloudPlatform
=>kubeflow
spark-on-k8s-operator
=>spark-operator
GoogleCloudPlatform/spark-on-k8s-operator
=>kubeflow/spark-operator
https://googlecloudplatform.github.io/spark-on-k8s-operator
=>https://kubeflow.github.io/spark-operator
Ref: #1929