Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace GoogleCloudPlatform/spark-on-k8s-operator with kubeflow/spark-operator #1937

Merged

Conversation

zevisert
Copy link
Contributor

This is a naïve++ (as in, I did review each change) find and replace of the terms:

  • GoogleCloudPlatform => kubeflow
  • spark-on-k8s-operator => spark-operator
  • GoogleCloudPlatform/spark-on-k8s-operator => kubeflow/spark-operator
  • https://googlecloudplatform.github.io/spark-on-k8s-operator => https://kubeflow.github.io/spark-operator

⚠️ I didn't try building anything or running any tests! I just wanted to get something up so that the migration from gcp's repo is addressed sooner than later. I also didn't change any documentation or anything.

Ref: #1929

@yuchaoran2011
Copy link
Contributor

@zevisert
Copy link
Contributor Author

zevisert commented Apr 8, 2024

@yuchaoran2011, my commit message has been amended

@yuchaoran2011
Copy link
Contributor

@zevisert Thanks. Please also fix the merge conflicts

@zevisert
Copy link
Contributor Author

zevisert commented Apr 8, 2024

@yuchaoran2011 Done

@zevisert
Copy link
Contributor Author

zevisert commented Apr 8, 2024

Actually, I rebased on master and found one more reference, I need one more commit

…w/spark-operator

Signed-off-by: Zev Isert <dev@zevisert.ca>
Copy link
Contributor

@yuchaoran2011 yuchaoran2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuchaoran2011, zevisert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7e34e7e into kubeflow:master Apr 8, 2024
3 checks passed
@zevisert zevisert deleted the replace-gcp-with-kubeflow branch April 8, 2024 18:27
@vara-bonthu
Copy link
Contributor

@zevisert Thanks for the PR! I noticed changes to Go files. Could you please confirm if you've had a chance to test those changes? If not, we could create an issue to validate and we can also look at addressing our e2e tests?

@zevisert
Copy link
Contributor Author

@vara-bonthu No, I tried to make that clear in the description; this was just a find and replace. Were there no tests run as part of this PR?

peter-mcclonski pushed a commit to TechnologyBrewery/spark-on-k8s-operator that referenced this pull request Apr 16, 2024
…w/spark-operator (kubeflow#1937)

Signed-off-by: Zev Isert <dev@zevisert.ca>
Signed-off-by: Peter McClonski <mcclonski_peter@bah.com>
@vzhao12
Copy link

vzhao12 commented Apr 17, 2024

This pr breaks all old images pull because in https://github.com/kubeflow/spark-operator/pkgs/container/spark-operator. There is no old version image available at all. Can you revert this pr or copy all image to the new place? Thanks

@vzhao12
Copy link

vzhao12 commented Apr 17, 2024

Please see the issue here. I don't think I will be the only one who has this issue.

@zevisert
Copy link
Contributor Author

@vzhao12 - I purposely didn't change the repository in this PR so as to not create issues like this. PR #1956 and PR #1974 have both changed the chart repository, but this PR did not.

sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
…w/spark-operator (kubeflow#1937)

Signed-off-by: Zev Isert <dev@zevisert.ca>
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
…w/spark-operator (kubeflow#1937)

Signed-off-by: Zev Isert <dev@zevisert.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants