Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated PySpark experimental warning in example #2014

Merged
merged 1 commit into from
May 9, 2024

Conversation

andrejpk
Copy link
Contributor

@andrejpk andrejpk commented May 7, 2024

Purpose of this PR

Confusing warning in the Python example that Python support is experimental. Python support seems stable in current versions, correct?

Proposed changes:
Remove outdated (?) warning in the pyspark example that Python support is experimental. (This was written 6 years ago)

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

This is confusing if no longer correct.

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

@andrejpk andrejpk changed the title Remove outdated PySpark preview warning in example Remove outdated PySpark experimental warning in example May 7, 2024
Signed-off-by: Andrej Kyselica <andrejky@microsoft.com>
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1d123ca into kubeflow:master May 9, 2024
7 checks passed
sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
Signed-off-by: Andrej Kyselica <andrejky@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants