-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart: add POD_NAME env for leader election #2039
Conversation
Signed-off-by: aakcht <aakcht@gmail.com>
@Aakcht Could you confirm if you have tested and deployed the Helm chart with this PR? Please provide evidence here |
Hi, @vara-bonthu ! Yes, I tested that with this change and with Please tell me if some other evidence is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm. This is a good catch. Thanks for the fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuchaoran2011 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: aakcht <aakcht@gmail.com>
Signed-off-by: aakcht <aakcht@gmail.com>
Purpose of this PR
PR #1983 made leader election resourcelock to work based on POD_NAME identity(see the changes in
main.go
file). However POD_NAME environment variable is not being passed to spark operator pod. This results in the error described in #1987.Resolves #1987 .
Proposed changes:
This PR adds POD_NAME environment variable to spark operator pods when leader_election is required.
Change Category
Indicate the type of change by marking the applicable boxes:
Rationale
Checklist
Before submitting your PR, please review the following:
Additional Notes