-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding an option to set the priority class for spark-operator pod #2043
Adding an option to set the priority class for spark-operator pod #2043
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
64f9a6e
to
fd66e32
Compare
Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>
fd66e32
to
ef2eb9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Could you please uplift the Chart version with this change?
Provide any test results if you have any.
Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>
Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vara-bonthu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* controller introduce - map of queues per spark app * Add MemoryLimit as option that will override spark pods limits (by using webhook) * Add qps and burst as a parameter * Add profiling option and export-pprof.sh script * Update minikube version in CI (kubeflow#2059) Signed-off-by: Cian Gallagher <cian.gallagher@zendesk.com> * Adding an option to set the priority class for spark-operator pod (kubeflow#2043) * feat: give an option to set the priority class for spark-operator pod Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com> * feat: bumped up helm chart version Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com> * fix: fixed issue with position of priorityClassName Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com> * Update api-docs, README.md and chart values Signed-off-by: bentzi <bnetzi@gmail.com> --------- Signed-off-by: Cian Gallagher <cian.gallagher@zendesk.com> Signed-off-by: bentzi <bnetzi@gmail.com> Co-authored-by: Cian Gallagher <cian.gallagher@zendesk.com> Co-authored-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>
…beflow#2043) * feat: give an option to set the priority class for spark-operator pod Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com> * feat: bumped up helm chart version Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com> * fix: fixed issue with position of priorityClassName Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>
…beflow#2043) * feat: give an option to set the priority class for spark-operator pod Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com> * feat: bumped up helm chart version Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com> * fix: fixed issue with position of priorityClassName Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>
…beflow#2043) * feat: give an option to set the priority class for spark-operator pod Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com> * feat: bumped up helm chart version Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com> * fix: fixed issue with position of priorityClassName Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>
Purpose of this PR
Adding an option to set the priority class for spark-operator pod. This will help in better managing the preemption of pods.
Proposed changes:
priorityClassName
forspark-operator
pod.Change Category
Indicate the type of change by marking the applicable boxes:
Checklist
Before submitting your PR, please review the following:
Additional Notes
spark-operator
pod started with custom priority.