Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an option to set the priority class for spark-operator pod #2043

Merged

Conversation

pkgajulapalli
Copy link
Contributor

@pkgajulapalli pkgajulapalli commented Jun 2, 2024

Purpose of this PR

Adding an option to set the priority class for spark-operator pod. This will help in better managing the preemption of pods.

Proposed changes:

  • Added an optional value in helm chart priorityClassName for spark-operator pod.

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

  1. Created a custom priority class.
$ k8s get priorityclass custom-priority-class -o yaml
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
  name: custom-priority-class
preemptionPolicy: PreemptLowerPriority
value: 10000
  1. Installed helm chart with values specifying the same priority class
image:
  repository: "my-spark-operator"
  tag: "latest"
priorityClassName: "custom-priority-class"
  1. spark-operator pod started with custom priority.
$ k8s describe pod spark-operator-6cfbb57c-bn5n6 | grep -i 'priority'
Priority:             10000
Priority Class Name:  custom-priority-class

Copy link

google-cla bot commented Jun 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pkgajulapalli pkgajulapalli force-pushed the feature/priority-classs branch 2 times, most recently from 64f9a6e to fd66e32 Compare June 2, 2024 06:11
Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Could you please uplift the Chart version with this change?
Provide any test results if you have any.

Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>
Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 0b67bae into kubeflow:master Jun 15, 2024
3 checks passed
@pkgajulapalli pkgajulapalli deleted the feature/priority-classs branch June 15, 2024 17:52
bnetzi added a commit to bnetzi/spark-operator that referenced this pull request Jun 16, 2024
* controller introduce - map of queues per spark app

* Add MemoryLimit as option that will override spark pods limits (by using webhook)

* Add qps and burst as a parameter

* Add profiling option and export-pprof.sh script

* Update minikube version in CI (kubeflow#2059)

Signed-off-by: Cian Gallagher <cian.gallagher@zendesk.com>

* Adding an option to set the priority class for spark-operator pod (kubeflow#2043)

* feat: give an option to set the priority class for spark-operator pod
Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>

* feat: bumped up helm chart version
Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>

* fix: fixed issue with position of priorityClassName
Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>

* Update api-docs, README.md and chart values

Signed-off-by: bentzi <bnetzi@gmail.com>

---------

Signed-off-by: Cian Gallagher <cian.gallagher@zendesk.com>
Signed-off-by: bentzi <bnetzi@gmail.com>
Co-authored-by: Cian Gallagher <cian.gallagher@zendesk.com>
Co-authored-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>
jacobsalway pushed a commit to jacobsalway/spark-operator that referenced this pull request Jul 25, 2024
…beflow#2043)

* feat: give an option to set the priority class for spark-operator pod
Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>

* feat: bumped up helm chart version
Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>

* fix: fixed issue with position of priorityClassName
Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>
sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
…beflow#2043)

* feat: give an option to set the priority class for spark-operator pod
Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>

* feat: bumped up helm chart version
Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>

* fix: fixed issue with position of priorityClassName
Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
…beflow#2043)

* feat: give an option to set the priority class for spark-operator pod
Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>

* feat: bumped up helm chart version
Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>

* fix: fixed issue with position of priorityClassName
Signed-off-by: Praveen Gajulapalli <13733716+pkgajulapalli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants