Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChenYi015 as spark-operator reviewer #2045

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

ChenYi015
Copy link
Contributor

@ChenYi015 ChenYi015 commented Jun 4, 2024

🛑 Important:

Please open an issue to discuss significant work before you start. We appreciate your contributions and don't want your efforts to go to waste!

For guidelines on how to contribute, please review the CONTRIBUTING.md document.

Purpose of this PR

Provide a clear and concise description of the changes. Explain the motivation behind these changes and link to relevant issues or discussions.

Proposed changes:

  • Add myself @ChenYi015 as spark-operator reviewer

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

I am currently a member of Kubeflow organization.

Contributed PRs: https://github.com/kubeflow/spark-operator/pulls?q=is%3Apr+author%3AChenYi015

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

@ChenYi015
Copy link
Contributor Author

/assign @yuchaoran2011

Copy link
Contributor

@yuchaoran2011 yuchaoran2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChenYi015 After discussions with fellow maintainers, we agree that your contributions should be recognized. We look forward to seeing you take on greater responsibility in the management of the repo over time. Let's do it step by step following the kubeflow guidelines: https://www.kubeflow.org/docs/about/contributing/#owners. As a start, could you update the PR to add yourself under reviewers? Then we can include you in the approvers list after a period of sustained contributions.

Signed-off-by: Yi Chen <github@chenyicn.net>
@ChenYi015 ChenYi015 changed the title Add ChenYi015 as spark-operator approvers Add ChenYi015 as spark-operator reviewer Jun 5, 2024
@ChenYi015
Copy link
Contributor Author

@yuchaoran2011 Ok, I have updated the PR to add myself as a reviewer.

Copy link
Contributor

@yuchaoran2011 yuchaoran2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jun 5, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vara-bonthu, yuchaoran2011

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [vara-bonthu,yuchaoran2011]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 089546e into kubeflow:master Jun 5, 2024
7 checks passed
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great contributions @ChenYi015 and congratulations to become Spark Operator maintainer 🎉

@ChenYi015 ChenYi015 deleted the owners branch July 18, 2024 09:26
jacobsalway pushed a commit to jacobsalway/spark-operator that referenced this pull request Jul 25, 2024
Signed-off-by: Yi Chen <github@chenyicn.net>
sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
Signed-off-by: Yi Chen <github@chenyicn.net>
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
Signed-off-by: Yi Chen <github@chenyicn.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants