-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ChenYi015 as spark-operator reviewer #2045
Conversation
/assign @yuchaoran2011 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChenYi015 After discussions with fellow maintainers, we agree that your contributions should be recognized. We look forward to seeing you take on greater responsibility in the management of the repo over time. Let's do it step by step following the kubeflow guidelines: https://www.kubeflow.org/docs/about/contributing/#owners. As a start, could you update the PR to add yourself under reviewers
? Then we can include you in the approvers list after a period of sustained contributions.
Signed-off-by: Yi Chen <github@chenyicn.net>
@yuchaoran2011 Ok, I have updated the PR to add myself as a reviewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vara-bonthu, yuchaoran2011 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your great contributions @ChenYi015 and congratulations to become Spark Operator maintainer 🎉
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
🛑 Important:
Please open an issue to discuss significant work before you start. We appreciate your contributions and don't want your efforts to go to waste!
For guidelines on how to contribute, please review the CONTRIBUTING.md document.
Purpose of this PR
Provide a clear and concise description of the changes. Explain the motivation behind these changes and link to relevant issues or discussions.
Proposed changes:
Change Category
Indicate the type of change by marking the applicable boxes:
Rationale
I am currently a member of Kubeflow organization.
Contributed PRs: https://github.com/kubeflow/spark-operator/pulls?q=is%3Apr+author%3AChenYi015
Checklist
Before submitting your PR, please review the following:
Additional Notes