Added the new CNCF slack channel to README.md #2062

vikas-saxena02 · 2024-06-14T18:55:24Z

🛑 Important:

This PR is for the change proposed in #2061

Purpose of this PR

The PR aims at providing the new CNCF slack Channel details so that new users can go to new slack channel instead of old slack channel which is going to be archived soon. See details here (#2061)

Proposed changes:

Update slack channel to CNCF Slack channel

Change Category

Indicate the type of change by marking the applicable boxes:

Bugfix (non-breaking change which fixes an issue)
Feature (non-breaking change which adds functionality)
Breaking change (fix or feature that could affect existing functionality)
Documentation update

Rationale

Users are currentl joining the old slack channel instead of the new one

Checklist

Before submitting your PR, please review the following:

I have conducted a self-review of my own code.
I have updated documentation accordingly.
I have added tests that prove my changes are effective or that my feature works.
Existing unit tests pass locally with my changes.

Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

andreyvelich

Thanks for this @vikas-saxena02!
I would appreciate if you could also update the blog post: https://github.com/kubeflow/blog/blob/master/_posts/2024-04-15-kubeflow-spark-operator.md

andreyvelich · 2024-06-14T19:25:11Z

README.md

@@ -91,5 +91,5 @@ Please check [CONTRIBUTING.md](CONTRIBUTING.md) and the [Developer Guide](docs/d

 ## Community

-* Join our [Kubeflow Slack Channel](https://kubeflow.slack.com/archives/C06627U3XU3)
+* Join our [Kubeflow Slack Channel](https://cloud-native.slack.com/archives/C074588U7EG)


Please can you link this page: https://www.kubeflow.org/docs/about/community/#kubeflow-slack-channels ?
Since folks need to join CNCF Slack before joining the #kubeflow-spark-operator channel.

on to it... will update by my EOD today

@andreyvelich @yuchaoran2011 I have incorporated both the review points in PR.

…oining slack channel to point to kubeflow website Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

andreyvelich · 2024-06-15T15:26:41Z

Thanks @vikas-saxena02!
Please can you open another PR to update the Slack channel in kubeflow/blog here: https://github.com/kubeflow/blog/blob/master/_posts/2024-04-15-kubeflow-spark-operator.md#join-the-movement.

vara-bonthu

/lgtm

vara-bonthu · 2024-06-15T16:48:54Z

README.md

@@ -91,5 +91,6 @@ Please check [CONTRIBUTING.md](CONTRIBUTING.md) and the [Developer Guide](docs/d

 ## Community

-* Join our [Kubeflow Slack Channel](https://kubeflow.slack.com/archives/C06627U3XU3)
+* Join [CNCF Slack Channel](https://www.kubeflow.org/docs/about/community/#kubeflow-slack-channels)


I think it's better provide the direct link to CNCF Kubeflow Spark Operator channel
replace the link with this one https://cloud-native.slack.com/archives/C074588U7EG

Previously, we got a feedback that if we provide this link and user is not member of CNCF slack, they can't join it: kubeflow/katib#2343

Ah, just checked the comment from Andrey on this. Maybe we can rephrase it as:

Join the CNCF Slack Channel #kubeflow-spark-operator for collaboration on the Spark Operator.

that sounds good

@vara-bonthu @andreyvelich please take a look again, I have updated the same. Happy to put a link to kubeflow-spark-operator as well if you think it would make more sense. I am double minded about it as it may confuse users and they may not end up clicking on first link to join the CNCF Slack Workspace

vara-bonthu · 2024-06-15T16:50:21Z

README.md

@@ -91,5 +91,6 @@ Please check [CONTRIBUTING.md](CONTRIBUTING.md) and the [Developer Guide](docs/d

 ## Community

-* Join our [Kubeflow Slack Channel](https://kubeflow.slack.com/archives/C06627U3XU3)
+* Join [CNCF Slack Channel](https://www.kubeflow.org/docs/about/community/#kubeflow-slack-channels)
+* Check out our blog post [Announcing the Kubeflow Spark Operator: Building a Stronger Spark on Kubernetes Community](https://github.com/kubeflow/blog/blob/master/_posts/2024-04-15-kubeflow-spark-operator.md)


replace the link with https://blog.kubeflow.org/operators/2024/04/15/kubeflow-spark-operator.html

vara-bonthu · 2024-06-15T16:51:18Z

/hold

Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

google-oss-prow · 2024-06-16T10:54:00Z

New changes are detected. LGTM label has been removed.

google-oss-prow · 2024-06-16T10:54:08Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from vara-bonthu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…lack_channel_details

Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

vikas-saxena02 · 2024-06-16T11:12:35Z

https://github.com/kubeflow/blog/blob/master/_posts/2024-04-15-kubeflow-spark-operator.md#join-the-movement

@andreyvelich please take a look at the change made in this PR and I will make an identical change in kubeflow/blog repository as mentioned by you.

Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

vikas-saxena02 · 2024-06-16T11:33:50Z

@vara-bonthu I am getting the following error ✖︎ spark-operator => (version: "1.4.1", path: "charts/spark-operator-chart") > chart version not ok. Needs a version bump! from Pre-commit check/build-helm-chart doI need to bump the operator version?

vara-bonthu · 2024-06-16T15:20:30Z

charts/spark-operator-chart/README.md

@@ -1,6 +1,6 @@
 # spark-operator

-![Version: 1.4.0](https://img.shields.io/badge/Version-1.4.0-informational?style=flat-square) ![AppVersion: v1beta2-1.6.0-3.5.0](https://img.shields.io/badge/AppVersion-v1beta2--1.6.0--3.5.0-informational?style=flat-square)
+![Version: 1.4.1](https://img.shields.io/badge/Version-1.4.1-informational?style=flat-square) ![AppVersion: v1beta2-1.6.0-3.5.0](https://img.shields.io/badge/AppVersion-v1beta2--1.6.0--3.5.0-informational?style=flat-square)


you don't have to change the version in your PR

vara-bonthu · 2024-06-16T15:21:07Z

charts/spark-operator-chart/README.md

@@ -110,7 +110,7 @@ See [helm uninstall](https://helm.sh/docs/helm/helm_uninstall) for command docum
 | podMonitor.labels | object | `{}` | Pod monitor labels |
 | podMonitor.podMetricsEndpoint | object | `{"interval":"5s","scheme":"http"}` | Prometheus metrics endpoint properties. `metrics.portName` will be used as a port |
 | podSecurityContext | object | `{}` | Pod security context |
-| priorityClassName | string | `""` | Priority class to be used for running spark-operator pod. This helps in managing the pods during preemption. |
+| priorityClassName | string | `""` | A priority class to be used for running spark-operator pod. |


you can exclude these changes

… "fixed Typos in README.md" This reverts commit 6d7eb4d.

Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

vikas-saxena02 · 2024-06-18T08:35:07Z

@vara-bonthu @andreyvelich I think I have screwed up my branch. i will do a new PR soon

Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

…w#2066) Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

google-oss-prow bot requested review from andreyvelich, ChenYi015 and yuchaoran2011 June 14, 2024 18:55

google-oss-prow bot added the size/XS label Jun 14, 2024

vikas-saxena02 added 2 commits June 15, 2024 04:56

Added the link of Slack channel to new CNCF slack channel

9ce8c52

Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

updated link to include workspace in the utl itself

9d992e6

Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

vikas-saxena02 force-pushed the Issue2061_add_new_slack_channel_details branch from 37880b0 to 9d992e6 Compare June 14, 2024 18:56

vikas-saxena02 changed the title ~~Added the link of Slack channel to new CNCF slack channel~~ Added the new CNCF slack channel to README.md Jun 14, 2024

andreyvelich reviewed Jun 14, 2024

View reviewed changes

vikas-saxena02 added 2 commits June 15, 2024 16:47

Added link to Kubeflow SparkOperator Blog Post and modified url for j…

6f7a7b9

…oining slack channel to point to kubeflow website Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

fixed link in README.md

1634b6d

Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

vara-bonthu reviewed Jun 15, 2024

View reviewed changes

google-oss-prow bot assigned vara-bonthu Jun 15, 2024

google-oss-prow bot added the lgtm label Jun 15, 2024

google-oss-prow bot added the do-not-merge/hold label Jun 15, 2024

Incorporated Vara's feedback on PR in README.md

0611c78

Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

google-oss-prow bot removed the lgtm label Jun 16, 2024

vikas-saxena02 added 2 commits June 16, 2024 20:55

Merge remote-tracking branch 'origin/master' into Issue2061_add_new_s…

c39584d

…lack_channel_details

fixed Typos in README.md

6d7eb4d

Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

fixing failed checks in the ci pipeline

9dd58cd

Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

vikas-saxena02 requested review from andreyvelich and vara-bonthu June 16, 2024 11:34

vara-bonthu reviewed Jun 16, 2024

View reviewed changes

Reverting the changes made due to running "make helm-docs". Revert to…

2854fce

… "fixed Typos in README.md" This reverts commit 6d7eb4d.

Rebased with master and resolved merage conflicts

2ae62f2

Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

Resolving merge conflicts

570f4a1

vikas-saxena02 closed this Jun 18, 2024

vikas-saxena02 deleted the Issue2061_add_new_slack_channel_details branch June 18, 2024 08:45

vikas-saxena02 added a commit to vikas-saxena02/spark-operator that referenced this pull request Jun 18, 2024

Modified README.MD s per changes discussed on kubeflow#2062

7645d6b

Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

google-oss-prow bot pushed a commit that referenced this pull request Jun 18, 2024

Modified README.MD as per changes discussed on #2062 (#2066)

d37ac38

Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

vikas-saxena02 mentioned this pull request Jun 18, 2024

Updating SparkOperator Blog post with CNCF slack channel details kubeflow/blog#149

Merged

jacobsalway pushed a commit to jacobsalway/spark-operator that referenced this pull request Jul 25, 2024

Modified README.MD as per changes discussed on kubeflow#2062 (kubeflo…

811ac04

…w#2066) Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024

Modified README.MD as per changes discussed on kubeflow#2062 (kubeflo…

185320b

…w#2066) Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added the new CNCF slack channel to README.md #2062

Added the new CNCF slack channel to README.md #2062

vikas-saxena02 commented Jun 14, 2024 •

edited

Loading

andreyvelich left a comment

andreyvelich Jun 14, 2024

vikas-saxena02 Jun 15, 2024

vikas-saxena02 Jun 15, 2024 •

edited

Loading

andreyvelich commented Jun 15, 2024

vara-bonthu left a comment

vara-bonthu Jun 15, 2024

andreyvelich Jun 15, 2024

vara-bonthu Jun 15, 2024

andreyvelich Jun 15, 2024

vikas-saxena02 Jun 16, 2024 •

edited

Loading

vara-bonthu Jun 15, 2024

vara-bonthu commented Jun 15, 2024

google-oss-prow bot commented Jun 16, 2024

google-oss-prow bot commented Jun 16, 2024

vikas-saxena02 commented Jun 16, 2024 •

edited

Loading

vikas-saxena02 commented Jun 16, 2024

vara-bonthu Jun 16, 2024

vara-bonthu Jun 16, 2024

vikas-saxena02 commented Jun 18, 2024

Added the new CNCF slack channel to README.md #2062

Added the new CNCF slack channel to README.md #2062

Conversation

vikas-saxena02 commented Jun 14, 2024 • edited Loading

🛑 Important:

Purpose of this PR

Change Category

Rationale

Checklist

andreyvelich left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vikas-saxena02 Jun 15, 2024 • edited Loading

Choose a reason for hiding this comment

andreyvelich commented Jun 15, 2024

vara-bonthu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vikas-saxena02 Jun 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vara-bonthu commented Jun 15, 2024

google-oss-prow bot commented Jun 16, 2024

google-oss-prow bot commented Jun 16, 2024

vikas-saxena02 commented Jun 16, 2024 • edited Loading

vikas-saxena02 commented Jun 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vikas-saxena02 commented Jun 18, 2024

vikas-saxena02 commented Jun 14, 2024 •

edited

Loading

vikas-saxena02 Jun 15, 2024 •

edited

Loading

vikas-saxena02 Jun 16, 2024 •

edited

Loading

vikas-saxena02 commented Jun 16, 2024 •

edited

Loading