Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for closing stale issues and PRs #2073

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

ChenYi015
Copy link
Contributor

Purpose of this PR

Add workflow for closing staled issues and PRs:

  • The issues/PRs will be marked as stale for 60 days with no activity and will be closed after 30 days with no activity.

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

Signed-off-by: Yi Chen <github@chenyicn.net>
@ChenYi015
Copy link
Contributor Author

/assign @vara-bonthu

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. I believe it's essential for maintaining the repo and encourages contributors to reopen PRs and issues if they still think they are necessary. Given the many open PRs and issues, this could close most of them.

I want to ensure all maintainers and reviewers are okay with this approach.
@yuchaoran2011 @andreyvelich

@yuchaoran2011
Copy link
Contributor

This will be a good topic for the community meeting next week. Let's gather more input before making a decision

Signed-off-by: Yi Chen <github@chenyicn.net>
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Jul 3, 2024
@ChenYi015 ChenYi015 changed the title Add workflow for closing staled issues and PRs Add workflow for closing stale issues and PRs Jul 15, 2024
@yuchaoran2011
Copy link
Contributor

As discussed during the most recent community call, attendees have agreed on giving this new process of managing issues and PRs a try
/lgtm

Copy link
Contributor

@yuchaoran2011 yuchaoran2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vara-bonthu, yuchaoran2011

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [vara-bonthu,yuchaoran2011]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8894a4f into kubeflow:master Jul 22, 2024
6 of 7 checks passed
@ChenYi015 ChenYi015 deleted the workflow/stale branch July 22, 2024 05:12
jacobsalway pushed a commit to jacobsalway/spark-operator that referenced this pull request Jul 25, 2024
* Add workflow for closing staled issues and PRs

Signed-off-by: Yi Chen <github@chenyicn.net>

* Add job permissions

Signed-off-by: Yi Chen <github@chenyicn.net>

---------

Signed-off-by: Yi Chen <github@chenyicn.net>
YanivKunda pushed a commit to YanivKunda/spark-operator that referenced this pull request Aug 5, 2024
* Add workflow for closing staled issues and PRs

Signed-off-by: Yi Chen <github@chenyicn.net>

* Add job permissions

Signed-off-by: Yi Chen <github@chenyicn.net>

---------

Signed-off-by: Yi Chen <github@chenyicn.net>
sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
* Add workflow for closing staled issues and PRs

Signed-off-by: Yi Chen <github@chenyicn.net>

* Add job permissions

Signed-off-by: Yi Chen <github@chenyicn.net>

---------

Signed-off-by: Yi Chen <github@chenyicn.net>
Kevinz857 pushed a commit to Kevinz857/spark-operator that referenced this pull request Aug 27, 2024
* Add workflow for closing staled issues and PRs

Signed-off-by: Yi Chen <github@chenyicn.net>

* Add job permissions

Signed-off-by: Yi Chen <github@chenyicn.net>

---------

Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Kevin Wu <kevin.wu@momenta.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants