Manually fix the CRD validation issue in k8s 1.18 #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jkleckner
pushed a commit
to jkleckner/spark-on-k8s-operator
that referenced
this pull request
Nov 24, 2020
PR kubeflow#1045 [1] appears to have accidentally reverted kubeflow#986 [2] which added defaults to the protocol field to work with versions of k8s 1.18+ This PR also draws on kudobuilder/operators#297 [3] [1] kubeflow#1045 [2] kubeflow#986 [3] kudobuilder/operators#297
|
Created a candidate PR here #1084 |
liyinan926
pushed a commit
that referenced
this pull request
Nov 25, 2020
PR #1045 [1] appears to have accidentally reverted #986 [2] which added defaults to the protocol field to work with versions of k8s 1.18+ This PR also draws on kudobuilder/operators#297 [3] [1] #1045 [2] #986 [3] kudobuilder/operators#297
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
PR kubeflow#1045 [1] appears to have accidentally reverted kubeflow#986 [2] which added defaults to the protocol field to work with versions of k8s 1.18+ This PR also draws on kudobuilder/operators#297 [3] [1] kubeflow#1045 [2] kubeflow#986 [3] kudobuilder/operators#297
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #921.