Add PVC for dev.kubeflow.org #139

pdmack · 2018-05-23T22:54:40Z

Hopefully, the d.k.o default StorageClass is good to go? :-)

This change is

pdmack · 2018-05-23T22:54:53Z

jlewi · 2018-05-24T01:19:45Z

Did you actually run recreate_app.sh? Can you do so and check in the new ksonnet app? Can you also run ks apply to actually update dev.kubeflow.org?

Bonus points for fixing .gitignore to check in vendor for the ksonnet app.

pdmack · 2018-05-24T03:28:50Z

@jlewi I don't know what "run ks apply to actually update dev.kubeflow.org" means. Adding the vendor dir and trying to ks apply led to lots of errors, starting with the seldon bits.

jlewi · 2018-05-24T03:33:58Z

dev-kubeflow-org/ks-app/app.yaml

@@ -3,32 +3,32 @@ environments:
  default:
    destination:
      namespace: kubeflow
-      server: https://35.188.73.10
+      server: https://10.19.47.136:6443


This looks like your minikube cluster. We probably need to point at the dev cluster before running recreate_app.sh

jlewi · 2018-05-24T03:35:58Z

This is great thanks for doing it.

By ks apply I meant run ks apply on the generated app to deploy it in dev.kubeflow.org

/lgtm
/approve
/hold

Feel free to submit as is just cancel the hold.

I put the hold in there just in case you want to try updating dev.kubeflow.org first.

The GKE cluster is in GCP project: kubeflow-dev

jlewi · 2018-05-24T22:48:28Z

Review status: 0 of 63 files reviewed at latest revision, 1 unresolved discussion.

dev-kubeflow-org/ks-app/components/issue-summarization.jsonnet, line 17 at r2 (raw file):

endpoint

Is this correct? Why is pvcName set to endpoint? Looks like a bug since you added the param pvcName

Comments from Reviewable

pdmack · 2018-05-24T23:49:55Z

Review status: 0 of 63 files reviewed at latest revision, 2 unresolved discussions.

dev-kubeflow-org/ks-app/components/issue-summarization.jsonnet, line 17 at r2 (raw file):

Previously, jlewi (Jeremy Lewi) wrote…

endpoint
Is this correct? Why is pvcName set to endpoint? Looks like a bug since you added the param pvcName

typo
Sorry, trying to deal with multiple issues spawned from the original PR

Comments from Reviewable

jlewi · 2018-05-25T00:12:36Z

Looks like @pdmack was just responding to the comment but didn't push a fix yet.
/issue-summarization.jsonnet

pdmack · 2018-05-25T18:33:37Z

/hold cancel
/lgtm

The PV and PVC are definitely created but I think I'll raise a separate issue regarding the fs mount.

# oc describe pv pvc-51019469-6048-11e8-9263-42010a8000db
Name:            pvc-51019469-6048-11e8-9263-42010a8000db
Labels:          failure-domain.beta.kubernetes.io/region=us-central1
                 failure-domain.beta.kubernetes.io/zone=us-central1-a
Annotations:     kubernetes.io/createdby=gce-pd-dynamic-provisioner
                 pv.kubernetes.io/bound-by-controller=yes
                 pv.kubernetes.io/provisioned-by=kubernetes.io/gce-pd
StorageClass:    standard
Status:          Bound
Claim:           kubeflow/claim-accounts-2egoogle-2ecom-3apmackinn-40redhat-2ecom
Reclaim Policy:  Delete
Access Modes:    RWO
Capacity:        10Gi
Message:
Source:
    Type:       GCEPersistentDisk (a Persistent Disk resource in Google Compute Engine)
    PDName:     gke-dev-cluster-22fdbd-pvc-51019469-6048-11e8-9263-42010a8000db
    FSType:     ext4
    Partition:  0
    ReadOnly:   false
Events:         <none>
# oc describe pvc claim-accounts-2egoogle-2ecom-3apmackinn-40redhat-2ecom
Name:          claim-accounts-2egoogle-2ecom-3apmackinn-40redhat-2ecom
Namespace:     kubeflow
StorageClass:  standard
Status:        Bound
Volume:        pvc-51019469-6048-11e8-9263-42010a8000db
Labels:        app=jupyterhub
               heritage=jupyterhub
               hub.jupyter.org/username=accounts_2Egoogle_2Ecom_3Apmackinn_40redhat_2Ecom
Annotations:   pv.kubernetes.io/bind-completed=yes
               pv.kubernetes.io/bound-by-controller=yes
               volume.beta.kubernetes.io/storage-provisioner=kubernetes.io/gce-pd
Finalizers:    []
Capacity:      10Gi
Access Modes:  RWO
Events:
  Type    Reason                 Age   From                         Message
  ----    ------                 ----  ----                         -------
  Normal  ProvisioningSucceeded  4m    persistentvolume-controller  Successfully provisioned volume pvc-51019469-6048-11e8-9263-42010a8000db using kubernetes.io/gce-pd

k8s-ci-robot · 2018-05-25T18:33:37Z

@pdmack: you cannot LGTM your own PR.

In response to this:

/hold cancel
/lgtm

The PV and PVC are definitely created but I think I'll raise a separate issue regarding the fs mount.

# oc describe pv pvc-51019469-6048-11e8-9263-42010a8000db
Name:            pvc-51019469-6048-11e8-9263-42010a8000db
Labels:          failure-domain.beta.kubernetes.io/region=us-central1
                failure-domain.beta.kubernetes.io/zone=us-central1-a
Annotations:     kubernetes.io/createdby=gce-pd-dynamic-provisioner
                pv.kubernetes.io/bound-by-controller=yes
                pv.kubernetes.io/provisioned-by=kubernetes.io/gce-pd
StorageClass:    standard
Status:          Bound
Claim:           kubeflow/claim-accounts-2egoogle-2ecom-3apmackinn-40redhat-2ecom
Reclaim Policy:  Delete
Access Modes:    RWO
Capacity:        10Gi
Message:
Source:
   Type:       GCEPersistentDisk (a Persistent Disk resource in Google Compute Engine)
   PDName:     gke-dev-cluster-22fdbd-pvc-51019469-6048-11e8-9263-42010a8000db
   FSType:     ext4
   Partition:  0
   ReadOnly:   false
Events:         <none>
# oc describe pvc claim-accounts-2egoogle-2ecom-3apmackinn-40redhat-2ecom
Name:          claim-accounts-2egoogle-2ecom-3apmackinn-40redhat-2ecom
Namespace:     kubeflow
StorageClass:  standard
Status:        Bound
Volume:        pvc-51019469-6048-11e8-9263-42010a8000db
Labels:        app=jupyterhub
              heritage=jupyterhub
              hub.jupyter.org/username=accounts_2Egoogle_2Ecom_3Apmackinn_40redhat_2Ecom
Annotations:   pv.kubernetes.io/bind-completed=yes
              pv.kubernetes.io/bound-by-controller=yes
              volume.beta.kubernetes.io/storage-provisioner=kubernetes.io/gce-pd
Finalizers:    []
Capacity:      10Gi
Access Modes:  RWO
Events:
 Type    Reason                 Age   From                         Message
 ----    ------                 ----  ----                         -------
 Normal  ProvisioningSucceeded  4m    persistentvolume-controller  Successfully provisioned volume pvc-51019469-6048-11e8-9263-42010a8000db using kubernetes.io/gce-pd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pdmack · 2018-05-25T18:38:54Z

Adding vendor/ means the kubeform_spawner.py needed to be blacklisted for pylint. Will port that over to kubeflow/kubeflow.

@jlewi with your lgtm, would like to move on.
/cc @texasmichelle

jlewi · 2018-05-25T19:29:54Z

/lgtm
/approve

Thank you so much!

k8s-ci-robot · 2018-05-25T19:29:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jlewi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot requested review from gaocegege and jimexist May 23, 2018 22:54

k8s-ci-robot added the size/XS label May 23, 2018

k8s-ci-robot requested a review from jlewi May 23, 2018 22:54

pdmack force-pushed the 854-verify-home-jovyan branch from 5842a37 to e647472 Compare May 24, 2018 03:13

k8s-ci-robot added size/XXL and removed size/XS labels May 24, 2018

pdmack force-pushed the 854-verify-home-jovyan branch from e647472 to 6acbc6a Compare May 24, 2018 03:25

k8s-ci-robot added size/L and removed size/XXL labels May 24, 2018

jlewi reviewed May 24, 2018

View reviewed changes

k8s-ci-robot added the do-not-merge/hold label May 24, 2018

k8s-ci-robot assigned jlewi May 24, 2018

k8s-ci-robot added lgtm approved labels May 24, 2018

pdmack force-pushed the 854-verify-home-jovyan branch from 6acbc6a to 2abc525 Compare May 24, 2018 18:07

k8s-ci-robot added size/XXL and removed lgtm size/L labels May 24, 2018

pdmack force-pushed the 854-verify-home-jovyan branch 3 times, most recently from da36990 to ceab16a Compare May 24, 2018 21:10

jlewi mentioned this pull request May 24, 2018

dev.kubeflow.org envoy; iap sidecar stuck waiting for backend kubeflow/kubeflow#871

Closed

pdmack force-pushed the 854-verify-home-jovyan branch from ceab16a to bfa79d8 Compare May 25, 2018 14:52

Add PVC for dev.kubeflow.org

c9bdb18

pdmack force-pushed the 854-verify-home-jovyan branch from bfa79d8 to c9bdb18 Compare May 25, 2018 18:27

k8s-ci-robot removed the do-not-merge/hold label May 25, 2018

k8s-ci-robot requested a review from texasmichelle May 25, 2018 18:38

k8s-ci-robot added the lgtm label May 25, 2018

k8s-ci-robot merged commit 6d3e487 into kubeflow:master May 25, 2018

pdmack deleted the 854-verify-home-jovyan branch May 29, 2018 16:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PVC for dev.kubeflow.org #139

Add PVC for dev.kubeflow.org #139

pdmack commented May 23, 2018 •

edited by jlewi

Loading

pdmack commented May 23, 2018

jlewi commented May 24, 2018

pdmack commented May 24, 2018

jlewi May 24, 2018

jlewi commented May 24, 2018

jlewi commented May 24, 2018

pdmack commented May 24, 2018

jlewi commented May 25, 2018

pdmack commented May 25, 2018

k8s-ci-robot commented May 25, 2018

pdmack commented May 25, 2018

jlewi commented May 25, 2018

k8s-ci-robot commented May 25, 2018

Add PVC for dev.kubeflow.org #139

Add PVC for dev.kubeflow.org #139

Conversation

pdmack commented May 23, 2018 • edited by jlewi Loading

pdmack commented May 23, 2018

jlewi commented May 24, 2018

pdmack commented May 24, 2018

jlewi May 24, 2018

Choose a reason for hiding this comment

jlewi commented May 24, 2018

jlewi commented May 24, 2018

pdmack commented May 24, 2018

jlewi commented May 25, 2018

pdmack commented May 25, 2018

k8s-ci-robot commented May 25, 2018

pdmack commented May 25, 2018

jlewi commented May 25, 2018

k8s-ci-robot commented May 25, 2018

pdmack commented May 23, 2018 •

edited by jlewi

Loading