Fix run_e2e_workflow #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimexist
approved these changes
Feb 15, 2018
|
|
||
| time.sleep(polling_interval.seconds) | ||
|
|
||
| return [] |
py/kubeflow/testing/py_checks.py
Outdated
| "vendor",] | ||
| full_dir_excludes = [os.path.join(os.path.abspath(args.src_dir), f) for f in | ||
| dir_excludes] | ||
| includes = ["*.py"] |
There was a problem hiding this comment.
would really benefit from Python3's Pathlib
py/kubeflow/testing/py_checks.py
Outdated
| topdown=True): | ||
| # excludes can be done with fnmatch.filter and complementary set, | ||
| # but it's more annoying to read. | ||
| exclude = False |
There was a problem hiding this comment.
can be extracted into a smaller functions:
def should_exclude(root, full_dir_excludes):
for e in full_dir_excludes:
if root.startswith(e):
return True
else:
return False
|
/lgtm |
|
@jimexist: changing LGTM is restricted to assignees, and assigning you to the PR failed. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test all |
This was referenced Feb 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_e2e_workflow.py is exiting with an exception causing all prow jobs to be marked as a failure
Add an E2E test to kubeflow/testing. This provides a way to test run_e2e_workflow.py as part of the presubmits.
Fix #30