Tekton pipeline client should use generate name #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
This change is |
* Use generateName to generate names for pipelines; we can use labels to attach semantic/metadata information to the pipeline. Related to kubeflow#682: tekton_client.py submitting pipelineruns with names that are too long * tekton_client should use PythonFire to generate the CLI rather than arg parser.
added 2 commits
June 15, 2020 15:10
|
/lgtm |
|
@Ark-kun Mostly cleanup related to testing the original change
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jlewi
pushed a commit
to jlewi/testing
that referenced
this pull request
Jun 16, 2020
* The CLI code isn't actually doing anything when invoked with "junit-and-upload". This was a bug introduced by kubeflow#683 Related to kubeflow#685
jlewi
pushed a commit
to jlewi/testing
that referenced
this pull request
Jun 16, 2020
* The CLI code isn't actually doing anything when invoked with "junit-and-upload". This was a bug introduced by kubeflow#683 Related to kubeflow#685
This was referenced Jun 16, 2020
k8s-ci-robot
pushed a commit
that referenced
this pull request
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to attach semantic/metadata information to the pipeline.
Related to #682: tekton_client.py submitting pipelineruns with names that
are too long