Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notebook test #722

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Fix notebook test #722

merged 1 commit into from
Jul 8, 2020

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Jul 8, 2020

  • artifacts-gcs on the image build step needs to match the run-notebook
    step

* artifacts-gcs on the image build step needs to match the run-notebook
  step
@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from Bobgy and rmgogogo July 8, 2020 03:36
@jlewi jlewi added the lgtm label Jul 8, 2020
@jlewi
Copy link
Contributor Author

jlewi commented Jul 8, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlewi
Copy link
Contributor Author

jlewi commented Jul 8, 2020

@k8s-ci-robot k8s-ci-robot merged commit c37f4bb into kubeflow:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants