Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tf-mnist-with-summaries in katib ECR list #970

Merged
merged 1 commit into from
Nov 13, 2021
Merged

Add tf-mnist-with-summaries in katib ECR list #970

merged 1 commit into from
Nov 13, 2021

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Nov 12, 2021 •
edited
Loading

Which issue is resolved by this Pull Request:
Related: kubeflow/katib#1731

Description of your changes:
We will use tf-mnist-with-summaries to test tfevent-metrics-collctor on EKS.

/assign @theofpa
/cc @kubeflow/wg-automl-leads

Checklist:

If PR related to Optional-Test-Infra,

  • Changes need to be generated to aws/GitOps folder:
    1. cd aws
    2. make optional-generate
    3. make optional-test

@google-cla google-cla bot added the cla: yes label Nov 12, 2021
andreyvelich
andreyvelich approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this @tenzen-y!
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Nov 12, 2021
PatrickXYS
PatrickXYS approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@PatrickXYS PatrickXYS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, PatrickXYS, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 747e47c into kubeflow:master Nov 13, 2021
@tenzen-y tenzen-y deleted the add-tf-mnist-with-summaries-image branch November 13, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyvelich andreyvelich andreyvelich approved these changes

@PatrickXYS PatrickXYS PatrickXYS approved these changes

Assignees

@theofpa theofpa

@PatrickXYS PatrickXYS

@andreyvelich andreyvelich

Labels
approved cla: yes lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tenzen-y @PatrickXYS @andreyvelich @theofpa