Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDK version to 1.5.0 #1624

Merged
merged 15 commits into from
Jun 28, 2022
Merged

Update SDK version to 1.5.0 #1624

merged 15 commits into from
Jun 28, 2022

Conversation

johnugeorge
Copy link
Member

Update SDK version to 1.5.0

@johnugeorge
Copy link
Member Author

/cc @alembiewski
/cc @terrytangyuan

@coveralls
Copy link

coveralls commented Jun 28, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2577571508

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 39.907%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 6 77.08%
Totals Coverage Status
Change from base Build 2576458714: 0.07%
Covered Lines: 2327
Relevant Lines: 5831
💛 - Coveralls

terrytangyuan
terrytangyuan approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jun 28, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnugeorge,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e1434f6 into kubeflow:master Jun 28, 2022
@johnugeorge johnugeorge mentioned this pull request Jun 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@gaocegege gaocegege Awaiting requested review from gaocegege

@jinchihe jinchihe Awaiting requested review from jinchihe

@alembiewski alembiewski Awaiting requested review from alembiewski

Assignees

@terrytangyuan terrytangyuan

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnugeorge @coveralls @terrytangyuan