-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update huggingface_hub
Version in the storage initializer to fix ImportError
#2180
Update huggingface_hub
Version in the storage initializer to fix ImportError
#2180
Conversation
Signed-off-by: helenxie-bit <helenxiehz@gmail.com>
Pull Request Test Coverage Report for Build 10026064625Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this error is irrelevant to the huggingface_hub
version.
Which peft
version do you use in your local?
I guess that your local peft
version is newer than v0.3.0:
peft==0.3.0 |
@tenzen-y My local
And here is the detailed information of the error:
Do you have any idea where the problem could be? |
@tenzen-y @helenxie-bit Getting the same error on my side with @tenzen-y @johnugeorge @deepanker13 Should we move this forward to fix errors in Additionally, @helenxie-bit if you could help us with some simple e2e tests for |
Yeah, of course. I can help with the e2e tests. |
SGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, we can merge it. Thanks @helenxie-bit!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…portError (kubeflow#2180) Signed-off-by: helenxie-bit <helenxiehz@gmail.com>
…portError (kubeflow#2180) Signed-off-by: helenxie-bit <helenxiehz@gmail.com> Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
* Update `huggingface_hub` Version in the storage initializer to fix ImportError (#2180) Signed-off-by: helenxie-bit <helenxiehz@gmail.com> Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * [SDK] Fix trainer error: Update the version of base image and add "num_labels" for downloading pretrained models (#2230) * fix trainer error Signed-off-by: helenxie-bit <helenxiehz@gmail.com> * rerun tests Signed-off-by: helenxie-bit <helenxiehz@gmail.com> * update the process of num_labels in trainer Signed-off-by: helenxie-bit <helenxiehz@gmail.com> * rerun tests Signed-off-by: helenxie-bit <helenxiehz@gmail.com> * adjust the default value of 'num_labels' Signed-off-by: helenxie-bit <helenxiehz@gmail.com> --------- Signed-off-by: helenxie-bit <helenxiehz@gmail.com> Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> --------- Signed-off-by: helenxie-bit <helenxiehz@gmail.com> Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Co-authored-by: Hezhi Xie <hezxie@ucdavis.edu> Co-authored-by: Hezhi (Helen) Xie <helenxiehz@gmail.com>
What this PR does / why we need it:
Due to the update of
huggingface_hub
,split_torch_state_dict_into_shards
is not supported in v0.19.3. Therefore, I updated the version in therequirements.txt
for the storage initializer to fix the "ImportError".Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #2179
Checklist: