Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc set_*_request as well as set_*_limit annotations #1954

Closed
amygdala opened this issue May 13, 2020 · 11 comments
Closed

doc set_*_request as well as set_*_limit annotations #1954

amygdala opened this issue May 13, 2020 · 11 comments

Comments

@amygdala
Copy link
Contributor

https://www.kubeflow.org/docs/gke/pipelines/enable-gpu-and-tpu/

Here and elsewhere we mention specifying k8s limits, e.g. set_gpu_limit. We should mention that set_xxx_request also works. e.g. https://github.com/kubeflow/pipelines/blob/62e33c711b12ebeb60d5fb393e9484f2b297bcac/sdk/python/kfp/dsl/_container_op.py#L249

(from a customer query)

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.73
area/pipelines 0.85

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/docs 0.94

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

1 similar comment
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/docs 0.94

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@janeman98
Copy link
Contributor

/cc @joeliedtke

@stale
Copy link

stale bot commented Aug 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@amygdala
Copy link
Contributor Author

let's keep open, still worthwhile...

@stale stale bot removed the lifecycle/stale label Aug 16, 2020
@stale
Copy link

stale bot commented Nov 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@amygdala
Copy link
Contributor Author

/lifecycle frozen

@Vipin0608
Copy link

Hi Can i work on this issue

@hbelmiro
Copy link
Contributor

@Vipin0608 this issue is from 4 years ago. The code of that page doesn't even exist in this repo anymore.
If you want to work on that, you need to do it at https://github.com/GoogleCloudPlatform/kubeflow-gke-docs.
I'm closing this issue.

/close

Copy link

@hbelmiro: Closing this issue.

In response to this:

@Vipin0608 this issue is from 4 years ago. The code of that page doesn't even exist in this repo anymore.
If you want to work on that, you need to do it at https://github.com/GoogleCloudPlatform/kubeflow-gke-docs.
I'm closing this issue.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants