-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update profile creation defaults to match current manifests #3023
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: surajkota The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The link you share is standalone deployment. Please check kustomize manifest. I remember this is overridden when kubeflow is deployment. not sure if flow has been changed or not. |
@Jeffwan this is from a fresh install using kustomize
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
closing in favour of #3146 |
reopened this as an alternative to #3146 until it is resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @surajkota!
I have one more suggestion on how to restructure this paragraph, which was not touched in this PR.
Kubeflow v1.4.0 provides automatic profile creation for authenticated users on first login. Additionally, an administrator can create a profile for any user in the Kubeflow cluster. Here an administrator is a person who has cluster-admin role binding in the Kubernetes cluster. This person has permissions to create and modify Kubernetes resources in the cluster. For example, the person who deployed Kubeflow will have administration privileges in the cluster.
to
An administrator can create a profile for any user in the Kubeflow cluster. Here an administrator is a person who has cluster-admin role binding in the Kubernetes cluster. This person has permissions to create and modify Kubernetes resources in the cluster. For example, the person who deployed Kubeflow will have administration privileges in the cluster.
We recommend this approach, since it encourages the adoption of GitOps processes for handling the Profile creation.
Kubeflow 1.4.0 also provides and automatic Profile creation workflow for authenticated users on first login.
Lastly, could you also do a pass in this page and update all 1.4.0 references to 1.5.0? We missed this in our grep effort previously.
@kimwnasptd Worked with Judy and came up with better organization and wording for a few sections. Please take a look Starting with Manual profile creation since it is the recommended approach |
@zijianjoy @joeliedtke ping for the link change in gke docs |
Thanks for the help @judyheflin! @surajkota the changes look very good, and also good catch to change the gke reference to the updated section. I think we are good to go |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: judyheflin, shannonbradshaw, surajkota The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Default is set to
false
- https://github.com/kubeflow/manifests/blob/master/apps/centraldashboard/upstream/base/params.env#L4