Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update profile creation defaults to match current manifests #3023

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

surajkota
Copy link
Contributor

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: surajkota
To complete the pull request process, please assign bobgy after the PR has been reviewed.
You can assign the PR to them by writing /assign @bobgy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jeffwan
Copy link
Member

Jeffwan commented Oct 14, 2021

The link you share is standalone deployment. Please check kustomize manifest. I remember this is overridden when kubeflow is deployment. not sure if flow has been changed or not.

@surajkota
Copy link
Contributor Author

surajkota commented Oct 14, 2021

@Jeffwan this is from a fresh install using kustomize

❯ kubectl get configmaps centraldashboard-parameters -o yaml
apiVersion: v1
data:
  CD_CLUSTER_DOMAIN: cluster.local
  CD_REGISTRATION_FLOW: "false"
  CD_USERID_HEADER: kubeflow-userid
  CD_USERID_PREFIX: ""
kind: ConfigMap
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"v1","data":{"CD_CLUSTER_DOMAIN":"cluster.local","CD_REGISTRATION_FLOW":"false","CD_USERID_HEADER":"kubeflow-userid","CD_USERID_PREFIX":""},"kind":"ConfigMap","metadata":{"annotations":{},"labels":{"app":"centraldashboard","app.kubernetes.io/component":"centraldashboard","app.kubernetes.io/name":"centraldashboard","kustomize.component":"centraldashboard"},"name":"centraldashboard-parameters","namespace":"kubeflow"}}
  creationTimestamp: "2021-10-14T21:52:41Z"
  labels:
    app: centraldashboard
    app.kubernetes.io/component: centraldashboard
    app.kubernetes.io/name: centraldashboard
    kustomize.component: centraldashboard
  name: centraldashboard-parameters
  namespace: kubeflow
  resourceVersion: "360055"
  selfLink: /api/v1/namespaces/kubeflow/configmaps/centraldashboard-parameters
  uid: 2fad0b36-faa2-44ff-9297-71eae1b259be

@surajkota
Copy link
Contributor Author

@Bobgy @yanniszark

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Mar 2, 2022
@surajkota
Copy link
Contributor Author

closing in favour of #3146

@surajkota
Copy link
Contributor Author

reopened this as an alternative to #3146 until it is resolved
@shannonbradshaw @kimwnasptd please take a look

Copy link
Member

@kimwnasptd kimwnasptd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @surajkota!

I have one more suggestion on how to restructure this paragraph, which was not touched in this PR.

Kubeflow v1.4.0 provides automatic profile creation for authenticated users on first login. Additionally, an administrator can create a profile for any user in the Kubeflow cluster. Here an administrator is a person who has cluster-admin role binding in the Kubernetes cluster. This person has permissions to create and modify Kubernetes resources in the cluster. For example, the person who deployed Kubeflow will have administration privileges in the cluster.

to

An administrator can create a profile for any user in the Kubeflow cluster. Here an administrator is a person who has cluster-admin role binding in the Kubernetes cluster. This person has permissions to create and modify Kubernetes resources in the cluster. For example, the person who deployed Kubeflow will have administration privileges in the cluster.

We recommend this approach, since it encourages the adoption of GitOps processes for handling the Profile creation.

Kubeflow 1.4.0 also provides and automatic Profile creation workflow for authenticated users on first login.

Lastly, could you also do a pass in this page and update all 1.4.0 references to 1.5.0? We missed this in our grep effort previously.

@surajkota
Copy link
Contributor Author

@kimwnasptd Worked with Judy and came up with better organization and wording for a few sections. Please take a look

Starting with Manual profile creation since it is the recommended approach

@surajkota
Copy link
Contributor Author

@zijianjoy @joeliedtke ping for the link change in gke docs

@kimwnasptd
Copy link
Member

Thanks for the help @judyheflin! @surajkota the changes look very good, and also good catch to change the gke reference to the updated section.

I think we are good to go
/lgtm

@shannonbradshaw
Copy link
Contributor

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: judyheflin, shannonbradshaw, surajkota

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shannonbradshaw
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot merged commit 7c1b2d4 into kubeflow:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants