Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployKF version to 1.8 #3746

Merged

Conversation

thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented May 29, 2024

Now that #3724 is merged, I can finally update the deployKF link (which was no longer correct) without causing merge conflicts.

Also, deployKF 0.1.5 now supports Kubeflow 1.8, so I have updated the table to reflect that.

@google-oss-prow google-oss-prow bot requested review from alfsuse and knkski May 29, 2024 19:13
@ederign
Copy link
Member

ederign commented May 29, 2024

/lgtm

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@thesuperzapper thesuperzapper force-pushed the update-deploykf-link branch from e589d7f to a87a87e Compare May 29, 2024 19:17
@google-oss-prow google-oss-prow bot removed the lgtm label May 29, 2024
@thesuperzapper
Copy link
Member Author

@ederign sorry, made a typo, please LGTM again!

@ederign
Copy link
Member

ederign commented May 29, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label May 29, 2024
@thesuperzapper
Copy link
Member Author

@andreyvelich can you please approve this update, it only affects deployKF.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thank you for the update @thesuperzapper!
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2aa56a3 into kubeflow:master May 29, 2024
6 checks passed
@thesuperzapper thesuperzapper deleted the update-deploykf-link branch September 4, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants