Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3829: Remove missing template preventing local build #3831

Conversation

franciscojavierarceo
Copy link
Contributor

@franciscojavierarceo franciscojavierarceo commented Jul 29, 2024

As outlined in #3829, the missing _internal/google_analytics_async.html script fails the local startup of the hugo server (as outlined in the docs).

I've removed the template code reference as it's not in the repo.

Let me know if this isn't the correct thing, happy to revise or update the docs accordingly.

I was also able to get the huge server to start up locally by just adding an empty file but I suspect that's not the correct solution.

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
@google-oss-prow google-oss-prow bot requested a review from james-jwu July 29, 2024 12:58
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jbottum for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -61,7 +61,5 @@
{{ $enableGtagForUniversalAnalytics := not .Site.Params.disableGtagForUniversalAnalytics -}}
{{ if (or $enableGtagForUniversalAnalytics (hasPrefix .Site.GoogleAnalytics "G-")) -}}
{{ template "_internal/google_analytics_gtag.html" . -}}
{{ else -}}
{{ template "_internal/google_analytics_async.html" . -}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we actually need this file. @thesuperzapper Do you know?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I mentioned that I was uncertain about this as the fix in my issue.

@thesuperzapper
Copy link
Member

@franciscojavierarceo @terrytangyuan I think the issue is probably just that you are running a version of Hugo that is too new.

See my comment in #3829 (comment).

@franciscojavierarceo
Copy link
Contributor Author

Thanks, Mathew. I'll double check. I thought I followed the instructions correctly but looks like I may have missed it. I'll confirm and close. Apologies!

@thesuperzapper
Copy link
Member

@franciscojavierarceo ok the issue was just that you had not run git submodule update --init --recursive, so were running an old version of the Docsy template.

/close

Copy link

@thesuperzapper: Closed this PR.

In response to this:

@franciscojavierarceo ok the issue was just that you had not run git submodule update --init --recursive, so were running an old version of the Docsy template.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants