-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 3829: Remove missing template preventing local build #3831
Issue 3829: Remove missing template preventing local build #3831
Conversation
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -61,7 +61,5 @@ | |||
{{ $enableGtagForUniversalAnalytics := not .Site.Params.disableGtagForUniversalAnalytics -}} | |||
{{ if (or $enableGtagForUniversalAnalytics (hasPrefix .Site.GoogleAnalytics "G-")) -}} | |||
{{ template "_internal/google_analytics_gtag.html" . -}} | |||
{{ else -}} | |||
{{ template "_internal/google_analytics_async.html" . -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we actually need this file. @thesuperzapper Do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I mentioned that I was uncertain about this as the fix in my issue.
@franciscojavierarceo @terrytangyuan I think the issue is probably just that you are running a version of Hugo that is too new. See my comment in #3829 (comment). |
Thanks, Mathew. I'll double check. I thought I followed the instructions correctly but looks like I may have missed it. I'll confirm and close. Apologies! |
@franciscojavierarceo ok the issue was just that you had not run /close |
@thesuperzapper: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As outlined in #3829, the missing
_internal/google_analytics_async.html
script fails the local startup of the hugo server (as outlined in the docs).I've removed the template code reference as it's not in the repo.
Let me know if this isn't the correct thing, happy to revise or update the docs accordingly.
I was also able to get the huge server to start up locally by just adding an empty file but I suspect that's not the correct solution.