Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update katib-config.md #3888

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

Rajakavitha1
Copy link
Contributor

@Rajakavitha1 Rajakavitha1 commented Sep 29, 2024

Fixes #3811 and #3813

Signed-off-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com>
Copy link

Hi @Rajakavitha1. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com>
Signed-off-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com>
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hbelmiro
Copy link
Contributor

/ok-to-test

@hbelmiro
Copy link
Contributor

cc @andreyvelich @johnugeorge

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @Rajakavitha1!

@@ -34,8 +34,6 @@ package = "netlify-plugin-checklinks"
"public/docs/components/pipelines/fonts/",
"public/docs/components/pipelines/legacy-v1/fonts/",

"public/docs/components/katib/",
"public/docs/components/kfserving/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we update the KFServing docs ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It seems like the broken link was fixed in another PR, but KFServing was not removed from the white list.
Since there are no more broken links (we can confirm it in the CI of this PR), it should be removed.

@andreyvelich
Copy link
Member

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4115c6a into kubeflow:master Sep 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken links in Katib
3 participants