-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update katib-config.md #3888
Update katib-config.md #3888
Conversation
Signed-off-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com>
Hi @Rajakavitha1. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com>
Signed-off-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @Rajakavitha1!
@@ -34,8 +34,6 @@ package = "netlify-plugin-checklinks" | |||
"public/docs/components/pipelines/fonts/", | |||
"public/docs/components/pipelines/legacy-v1/fonts/", | |||
|
|||
"public/docs/components/katib/", | |||
"public/docs/components/kfserving/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we update the KFServing docs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. It seems like the broken link was fixed in another PR, but KFServing was not removed from the white list.
Since there are no more broken links (we can confirm it in the CI of this PR), it should be removed.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #3811 and #3813