Fix idtyp issue with GetMemberGroupsUsingARCOboService #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanohar
approved these changes
Jun 11, 2024
Signed-off-by: vithumma_microsoft <Vineeth.Thumma@microsoft.com>
Signed-off-by: vithumma_microsoft <Vineeth.Thumma@microsoft.com>
Signed-off-by: vithumma_microsoft <Vineeth.Thumma@microsoft.com>
Signed-off-by: vithumma_microsoft <Vineeth.Thumma@microsoft.com>
bcho
approved these changes
Jun 12, 2024
julienstroheker
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing authentication flow in Guard for a user token (with overage claims), noticed that it is treated as SPN/Application and failed the authentication
Looks like Microsoft identity platform has changed the format for user tokens and is now setting optional "idtyp" claim. This needs a change in Guard on how we evaluate if the token corresponds to an AAD User or an Application (SPN)
For more context,
"idtyp" claim is used to get the type of token (app, user, device). By default, it's only emitted for app-only tokens (which seems to have changed now)
Like all optional claims that affect the access token, the resource in the request must set this optional claim, since resources own the access token
https://learn.microsoft.com/en-us/entra/identity-platform/optional-claims-reference#additionalproperties-of-optional-claims