change log (#3042)

* change log * check param for argEbgpMultihopTtl
kubeovn · Jul 17, 2023 · 494209d · 494209d
1 parent b40c35b
commit 494209d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/pkg/speaker/config.go b/pkg/speaker/config.go
@@ -110,6 +110,9 @@ func ParseFlags() (*Configuration, error) {
 	if *argNeighborIPv6Address != "" && net.ParseIP(*argNeighborIPv6Address).To16() == nil {
 		return nil, fmt.Errorf("invalid neighbor-ipv6-address format: %s", *argNeighborIPv6Address)
 	}
+	if *argEbgpMultihopTtl < 1 || *argEbgpMultihopTtl > 255 {
+		return nil, errors.New("the bgp MultihopTtl must be in the range 1 to 255")
+	}
 
 	config := &Configuration{
 		AnnounceClusterIP:           *argAnnounceClusterIP,

diff --git a/pkg/speaker/subnet.go b/pkg/speaker/subnet.go
@@ -44,7 +44,6 @@ func isClusterIPService(svc *v1.Service) bool {
 		len(svc.Spec.ClusterIP) != 0
 }
 
-// TODO: ipv4 only, need ipv6/dual-stack support later
 func (c *Controller) syncSubnetRoutes() {
 	maskMap := map[string]int{kubeovnv1.ProtocolIPv4: 32, kubeovnv1.ProtocolIPv6: 128}
 	bgpExpected, bgpExists := make(map[string][]string), make(map[string][]string)