Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace command health check with k8s tcpSocket check #1251

Merged
merged 4 commits into from
Feb 8, 2022
Merged

feat: Replace command health check with k8s tcpSocket check #1251

merged 4 commits into from
Feb 8, 2022

Conversation

sober-wang
Copy link
Contributor

I want try to contributor the project. so find the #1150 is a good first issue.

@oilbeater
Copy link
Collaborator

@sober-wang you should also update the install.sh script

successThreshold: 1
tcpSocket:
port: 10665
timeoutSeconds: 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timeoutSeconds should be long enough, when the system load is high it may not response in 1 second

successThreshold: 1
tcpSocket:
port: 10665
timeoutSeconds: 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@oilbeater
Copy link
Collaborator

timeoutSeconds should be increased to 10, and please squash the commits into one

@zhangzujian
Copy link
Member

yamls/kube-ovn-ipv6.yaml and yamls/kube-ovn-dual-stack.yaml should be updated too.

@sober-wang
Copy link
Contributor Author

yamls/kube-ovn-ipv6.yaml and yamls/kube-ovn-dual-stack.yaml should be updated too.

Thanks for your point out.

@oilbeater
Copy link
Collaborator

@sober-wang
Copy link
Contributor Author

sober-wang commented Jan 15, 2022

please check https://stackoverflow.com/questions/25356810/git-how-to-squash-all-commits-on-branch to squash commits

Your mean's Should I created a branch, next the pull request from the new branch?

And the commit describe struct is fails.

@zhangzujian
Copy link
Member

@sober-wang Merge the changes into one commit, and then force push to the PR's source branch sober-wang:master.

Squash my last X commits together using Git

@oilbeater oilbeater merged commit cb1a698 into kubeovn:master Feb 8, 2022
@oilbeater
Copy link
Collaborator

Squashed the commit by github squash merge. Thanks! @sober-wang

lut777 pushed a commit that referenced this pull request Sep 20, 2022
* feat: Replace command health check with k8s tcpSocket check
lut777 pushed a commit that referenced this pull request Sep 20, 2022
* feat: Replace command health check with k8s tcpSocket check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants