-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replace command health check with k8s tcpSocket check #1251
Conversation
@sober-wang you should also update the |
yamls/kube-ovn.yaml
Outdated
successThreshold: 1 | ||
tcpSocket: | ||
port: 10665 | ||
timeoutSeconds: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timeoutSeconds
should be long enough, when the system load is high it may not response in 1 second
yamls/kube-ovn.yaml
Outdated
successThreshold: 1 | ||
tcpSocket: | ||
port: 10665 | ||
timeoutSeconds: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
|
…venessProbe and readinessProbe
|
Thanks for your point out. |
please check https://stackoverflow.com/questions/25356810/git-how-to-squash-all-commits-on-branch to squash commits |
Your mean's Should I created a branch, next the pull request from the new branch? And the commit describe struct is fails. |
@sober-wang Merge the changes into one commit, and then force push to the PR's source branch sober-wang:master. |
Squashed the commit by github squash merge. Thanks! @sober-wang |
* feat: Replace command health check with k8s tcpSocket check
* feat: Replace command health check with k8s tcpSocket check
I want try to contributor the project. so find the #1150 is a good first issue.