fix: delete pod panic when delete vm or statefulset. #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongzhen-ma
reviewed
May 30, 2022
| if err != nil { | ||
| if k8serrors.IsNotFound(err) { | ||
| return true, nil | ||
| } |
There was a problem hiding this comment.
What about other errors?
There was a problem hiding this comment.
It's better to add a log here if don't need to process other errors.
hongzhen-ma
approved these changes
May 30, 2022
when vm is deleted, get vm != nil; need use err == isNotFound. add log for other errors when get vm or statefulset
hongzhen-ma
pushed a commit
that referenced
this pull request
May 30, 2022
when vm is deleted, get vm != nil; need use err == isNotFound. add log for other errors when get vm or statefulset
hongzhen-ma
pushed a commit
that referenced
this pull request
May 30, 2022
when vm is deleted, get vm != nil; need use err == isNotFound. add log for other errors when get vm or statefulset
|
已回合release-1.9 和 release-1.10 分支 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry, if vm or statefulset is deleted, vm or statefulset != nil; so need use err == isNotFound.
What type of this PR
Examples of user facing changes: