Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ovs bridge not deleted cause by port link not found #2084

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

zhangzujian
Copy link
Member

What type of this PR

  • Bug fixes

Which issue(s) this PR fixes:

When handling provider network deletion, if the host nic does not exist, kube-ovn-cni reports an error and the ovs bridge will be never deleted:

E1126 06:27:15.639671   13460 init.go:172] failed to remove port eth2 from external bridge br-pn-5034: failed to get nic by name eth2: Link not found
E1126 06:27:15.639727   13460 controller.go:220] error syncing 'pn-5034': failed to remove port eth2 from external bridge br-pn-5034: failed to get nic by name eth2: Link not found, requeuing

In this kind of scenario, we should ignore the error and finish the bridge deletion.

@zhangzujian zhangzujian added bug Something isn't working need backport labels Nov 26, 2022
@zhangzujian zhangzujian marked this pull request as ready for review November 26, 2022 08:53
@zhangzujian zhangzujian changed the title fix link not found when deleting provider network fix ovs bridge not deleted cause by port link not found Nov 26, 2022
pkg/daemon/ovs_linux.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need backport
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants