Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iptables: use the same mode with kube-proxy #2535

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Mar 21, 2023

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes:

Fixes submariner integration in ubuntu 22.04.

https://github.com/kubernetes-sigs/iptables-wrappers/blob/master/README.md

@zhangzujian zhangzujian force-pushed the iptables branch 5 times, most recently from ffba1ee to f5a433d Compare March 22, 2023 10:25
@zhangzujian zhangzujian marked this pull request as ready for review March 22, 2023 10:34
@zhangzujian zhangzujian linked an issue Mar 22, 2023 that may be closed by this pull request
dist/images/iptables-wrapper-installer.sh Outdated Show resolved Hide resolved
pkg/daemon/controller_linux.go Outdated Show resolved Hide resolved
pkg/daemon/controller_linux.go Outdated Show resolved Hide resolved
@zhangzujian zhangzujian force-pushed the iptables branch 4 times, most recently from 6b6e5d0 to 23312f2 Compare March 27, 2023 06:24
@github-actions
Copy link
Contributor

  • The commit message should be more descriptive and informative.
  • There are no potential bugs or format errors in the code patch.
  • It is unclear if there are any performance issues without further context.
  • It would be helpful to include comments explaining the purpose of each function and variable.
  • Consider using more descriptive variable names to improve readability.

@github-actions
Copy link
Contributor

  • The commit message should be more descriptive and informative.
  • There are no potential bugs or format errors in the code patch.
  • It is unclear if there are any performance issues without further context.
  • It would be helpful to include comments explaining the purpose of each function and variable.

@github-actions
Copy link
Contributor

  • The commit message should be more descriptive and informative. It should clearly state what changes were made and why.
  • There are no potential bugs or format errors in the diff.
  • It is difficult to assess performance issues without further context on the codebase and the changes made.
  • It would be helpful to include some examples or use cases for the changes made in the commit message.
  • The patch could benefit from additional comments in the code to explain the reasoning behind certain decisions or to clarify any complex logic.

@github-actions
Copy link
Contributor

  • The commit message should be more descriptive and informative. It should clearly state what changes were made and why.
  • There are no potential bugs or format errors in the diff.
  • It is difficult to assess performance issues without more context about the code being changed.
  • It would be helpful to include comments in the code explaining the purpose of each change and how it improves the code.
  • Consider adding unit tests to ensure that the changes do not introduce new bugs or regressions.

@zhangzujian zhangzujian merged commit 6d50bdc into kubeovn:master Apr 1, 2023
@zhangzujian zhangzujian deleted the iptables branch April 1, 2023 02:43
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request May 6, 2023
zhangzujian added a commit that referenced this pull request May 6, 2023
* iptables: use the same mode with kube-proxy (#2535)

* build base images for pr on necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect iptables version and use the same mode with kube-proxy
2 participants