Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace lb function call with ovnClient #2598

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

gugulee
Copy link
Contributor

@gugulee gugulee commented Apr 4, 2023

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes:

#2453

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

  • The commit message should be more descriptive and informative. It should clearly state what changes were made and why.
  • There are no potential bugs or format errors in the diff.
  • It is difficult to assess performance issues without more context about the code being changed.
  • It would be helpful to include comments in the code explaining the purpose of each change and any potential edge cases that were considered.
  • Consider adding unit tests to ensure that the changes do not introduce new bugs or regressions.
  • It may be beneficial to refactor some of the code for readability and maintainability.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

  • The commit message should be more descriptive and informative. It should clearly state what changes were made and why.
  • There are no potential bugs or format errors in the diff.
  • It is difficult to assess performance issues without more context about the code being changed.
  • It would be helpful to include comments in the code explaining the purpose of each change and how it improves the code.
  • It would be beneficial to include unit tests to ensure that the changes do not introduce new bugs or regressions.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

  • The commit message should be more descriptive and informative. It should clearly state what changes were made and why.
  • There are no potential bugs or format errors in the patch diff.
  • It is difficult to assess performance issues without further context on the codebase and the changes made.
  • Ways to improve could include adding comments to explain complex logic, refactoring repetitive code, and adhering to consistent coding style guidelines.

@zhangzujian zhangzujian added the performance Anything that can make Kube-OVN faster label Apr 4, 2023
@zhangzujian zhangzujian self-requested a review April 4, 2023 04:16
@zhangzujian zhangzujian merged commit 1a474fd into kubeovn:master Apr 4, 2023
@gugulee gugulee deleted the perf/libovsdb branch April 6, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Anything that can make Kube-OVN faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants