-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netpol: fix packet drop casued by incorrect address set deletion #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
oilbeater
approved these changes
Apr 19, 2023
hongzhen-ma
approved these changes
Apr 20, 2023
zhangzujian
added a commit
that referenced
this pull request
Apr 20, 2023
zhangzujian
added a commit
that referenced
this pull request
Apr 20, 2023
zhangzujian
added a commit
that referenced
this pull request
Apr 20, 2023
zhangzujian
added a commit
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Which issue(s) this PR fixes:
Fixes #(issue-number)
WHAT
🤖 Generated by Copilot at 7ca8b88
Simplify network policy controller by removing address set deletion logic. This improves performance and consistency with the address set controller.
🤖 Generated by Copilot at 7ca8b88
HOW
🤖 Generated by Copilot at 7ca8b88
network_policy.go
). This avoids unnecessary deletion and recreation of address sets, which can cause performance issues and inconsistency in the OVN database. The address sets are now managed by a separate controller that handles the creation, update and deletion of address sets based on the pod and namespace labels, and the network policy controller only needs to reference the existing address sets by name.