Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinger: use fully qualified domain name #3032

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Jul 12, 2023

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes:

Avoid DNS requests for invalid domains such as alauda.cn.svc.cluster.local.

WHAT

🤖 Generated by Copilot at 1583422

This pull request updates the external-dns argument values for the pinger component in different network configurations. It uses google.com. as a more reliable external DNS server and adds dots at the end of the domain names to improve DNS resolution. The affected files are ./charts/values.yaml, yamls/kube-ovn-dual-stack.yaml, yamls/kube-ovn-ipv6.yaml, and yamls/kube-ovn.yaml.

🤖 Generated by Copilot at 1583422

Sing, O Muse, of the cunning coder who changed the pinger's domain
From alauda.cn to google.com., a more reliable name
As swift as Hermes, he altered the arguments for dual-stack and IPv6
And added a dot for IPv4, like a Cyclops' single eye

HOW

🤖 Generated by Copilot at 1583422

  • Add a dot at the end of the external DNS domain name for the pinger component to improve DNS resolution (link, link, link, link)
  • Replace the external DNS domain name from alauda.cn to google.com. for the dual-stack and IPv6 configurations to use a more reliable and widely available DNS server (link, link)

@zhangzujian zhangzujian merged commit 9d88e49 into kubeovn:master Jul 12, 2023
@zhangzujian zhangzujian deleted the fix-dns branch July 12, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants