fix: nil pointer #4190
Merged
fix: nil pointer #4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zcq98 can you add a ut for this? |
|
在 IPAM Init 过程中判断 subnet 是否 ready，是否更合理？ |
好的，我再去看看代码 |
zcq98
force-pushed
the
fix-nil-pointer
branch
2 times, most recently
from
9fa15f0
to
d317e46
Compare
zhangzujian
reviewed
Jun 20, 2024
zhangzujian
approved these changes
Jun 20, 2024
Signed-off-by: zcq98 <zhaocongqi_yewu@cmss.chinamobile.com>
zhangzujian
pushed a commit
that referenced
this pull request
Jun 21, 2024
Signed-off-by: zcq98 <zhaocongqi_yewu@cmss.chinamobile.com> Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
bobz965
pushed a commit
that referenced
this pull request
Jun 21, 2024
Signed-off-by: zcq98 <zhaocongqi_yewu@cmss.chinamobile.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #4186