fix vpcnatgw image is not synced #4264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: oilbeater <liumengxinfly@gmail.com>
bobz965
approved these changes
Jul 8, 2024
oilbeater
added a commit
that referenced
this pull request
Jul 9, 2024
Signed-off-by: oilbeater <liumengxinfly@gmail.com>
bobz965
pushed a commit
that referenced
this pull request
Jul 22, 2024
Signed-off-by: oilbeater <liumengxinfly@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
The vpc-nat-gw image will only be updated when both the
ovn-vpc-nat-gw-configandovn-vpc-nat-configare changed. This PR split the logical, now changing the vpc-nat-gw image only need to change theovn-vpc-nat-config.I have write an e2e about this and it passed. However, when running together with other cases I meet other issues when quickly adding and deleting vpc and subnet with same name. I will fix them later and add the e2e together in another PR.
Which issue(s) this PR fixes
Fixes #(issue-number)