when router is deleted return success for static route deletion #4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oilbeater
changed the title
Signed-off-by: oilbeater <liumengxinfly@gmail.com>
oilbeater
force-pushed
the
fix/subnet-route-del
branch
from
3bd10b1
to
f97856d
Compare
bobz965
approved these changes
Jul 8, 2024
oilbeater
added a commit
that referenced
this pull request
Jul 9, 2024
Signed-off-by: oilbeater <liumengxinfly@gmail.com>
bobz965
pushed a commit
that referenced
this pull request
Jul 22, 2024
Signed-off-by: oilbeater <liumengxinfly@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: oilbeater liumengxinfly@gmail.com# Pull Request
What type of this PR
When in E2E vpc may be deleted before related subnet. Then subnet cannot delete the static route as the router is already not exist.
Which issue(s) this PR fixes
Fixes #(issue-number)