Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add loop check for tunnel nic #4736

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

dolibali
Copy link
Contributor

@dolibali dolibali commented Nov 15, 2024

Pull Request

What type of this PR

Examples of user facing changes:

  • Features

Which issue(s) this PR fixes

Fixes #4705

Signed-off-by: dolibali <zhangzihao2_yewu@cmss.chinamobile.com>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. feature New network feature labels Nov 15, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 15, 2024
@bobz965
Copy link
Collaborator

bobz965 commented Nov 15, 2024

@oilbeater could you help review?

@zhangzujian
Copy link
Member

// This method checks the status of the tunnel interface 
pkg/daemon/ovs_linux.go:722: File is not `gofumpt`-ed with `-extra` (gofumpt)
	
pkg/daemon/ovs_linux.go:729: File is not `gofumpt`-ed with `-extra` (gofumpt)
		//TODO: tunnelNic = "stt tunnel nic name"
pkg/daemon/ovs_linux.go:736: File is not `gofumpt`-ed with `-extra` (gofumpt)
	if err != nil || link == nil{
pkg/daemon/ovs_linux.go:738: File is not `gofumpt`-ed with `-extra` (gofumpt)
	} 
pkg/daemon/ovs_linux.go:7[45](https://github.com/kubeovn/kube-ovn/actions/runs/11852377974/job/33030447796?pr=4736#step:16:46): File is not `gofumpt`-ed with `-extra` (gofumpt)
	} 
pkg/util/const.go:136: File is not `gofumpt`-ed with `-extra` (gofumpt)
	VxlanNic = "vxlan_sys_[47](https://github.com/kubeovn/kube-ovn/actions/runs/11852377974/job/33030447796?pr=4736#step:16:48)89"

Signed-off-by: dolibali <zhangzihao2_yewu@cmss.chinamobile.com>
@oilbeater oilbeater merged commit ae4ce37 into kubeovn:master Nov 18, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New network feature lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] kubeovn 1.11.13 ovs vxlan_sys_4789 down
4 participants