bootstrap-tools are required for kured bin #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evrardjp
force-pushed
the
improve_makefile
branch
from
d001ea3
to
423c205
Compare
|
I need to update this to make the same change for all the commands using goreleaser |
dholbach
previously approved these changes
Nov 5, 2024
kured linking needs the goreleaser command line, yet it does not ensure it is present. This fixes it by ensuring the bootstrap-tools are always fetched first and used for all the make targets requiring them. Signed-off-by: Jean-Philippe Evrard <open-source@a.spamming.party>
evrardjp
force-pushed
the
improve_makefile
branch
from
423c205
to
7c31842
Compare
|
@dholbach can you review this again? |
dholbach
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kured linking needs the goreleaser command line, yet it does not ensure it is present.
This fixes it by ensuring the bootstrap-tools are always fetched first.