Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/prometheus/common from 0.57.0 to 0.60.0 #980

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 1, 2024

Bumps github.com/prometheus/common from 0.57.0 to 0.60.0.

Release notes

Sourced from github.com/prometheus/common's releases.

v0.60.0

What's Changed

Full Changelog: prometheus/common@v0.59.1...v0.60.0

v0.59.1

What's Changed

Full Changelog: prometheus/common@v0.59.0...v0.59.1

v0.59.0

What's Changed

Full Changelog: prometheus/common@v0.58.0...v0.59.0

v0.58.0

What's Changed

Full Changelog: prometheus/common@v0.57.0...v0.58.0

Commits
  • dae848d Update supported Go versions (#700)
  • 63ff77e Bump golang.org/x/oauth2 from 0.22.0 to 0.23.0 (#698)
  • b7aa68c Bump golang.org/x/net from 0.28.0 to 0.29.0 (#699)
  • 4e3a6fd feat: add promslog.NewNopLogger() convenience func (#697)
  • d66e745 promslog: use UTC timestamps for go-kit log style (#696)
  • 14bac55 Merge pull request #695 from prometheus/repo_sync
  • 8bc4cd5 Update common Prometheus files
  • 40d6251 Merge pull request #694 from jkroepke/slog/writer
  • fa21dfd Update common Prometheus files (#692)
  • 5f9af24 slog: expose io.Writer
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 1, 2024
@dholbach
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/common-0.60.0 branch 2 times, most recently from 49b21f0 to b4dbad9 Compare October 11, 2024 14:06
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.57.0 to 0.60.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Changelog](https://github.com/prometheus/common/blob/main/RELEASE.md)
- [Commits](prometheus/common@v0.57.0...v0.60.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/common-0.60.0 branch from b4dbad9 to 2eec401 Compare October 17, 2024 21:42
@evrardjp
Copy link
Collaborator

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 17, 2024

Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@evrardjp
Copy link
Collaborator

I can't see fossa results. Here is my analysis.

To remove the dependency on prometheus/common, we need to replace the model.Vector, model.ValVector, and model.AlertNameLabel with custom types or raw data handling that directly processes Prometheus API responses.

This will likely involve a significant refactoring. We'd have to rewrite the code to parse and handle Prometheus query results manually, which could be complex and error-prone.

Legally, I am not sure if importing and linking prometheus/common/model from the common package is the same as linking prometheus/common. As I haven't seen what causes the license conflict, I cannot propose a way forward as of today, without my fossa account fixed.

Copy link
Collaborator

@evrardjp evrardjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weirdly, FOSSA is now passing since the rebase. I can merge, then. If someone opposes, please (ask for) revert.

@evrardjp evrardjp merged commit 6b7d9be into main Oct 17, 2024
32 checks passed
@evrardjp evrardjp deleted the dependabot/go_modules/github.com/prometheus/common-0.60.0 branch October 17, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants