Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first draft #124

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

first draft #124

wants to merge 1 commit into from

Conversation

dholbach
Copy link
Member

@dholbach dholbach commented Jul 8, 2024

No description provided.

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for kured ready!

Name Link
🔨 Latest commit 8fdc922
🔍 Latest deploy log https://app.netlify.com/sites/kured/deploys/66b27f009ba91b0008f92a5f
😎 Deploy Preview https://deploy-preview-124--kured.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jackfrancis
jackfrancis previously approved these changes Jul 8, 2024
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great first post, lgtm!

ckotzbauer
ckotzbauer previously approved these changes Jul 9, 2024
Copy link
Member

@ckotzbauer ckotzbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great post, I like it ❤️

@evrardjp
Copy link
Contributor

I like the concept!

I am afraid some of it might become outdated with the code changes. I believe code structure should be in another place (contributing.md or architecture reference), and we should simply point to it. WDYT?

WDYT about mentioning the rate of changes (and their releasing) and our mentality? I think mentioning "feature complete" is something important, and the rest is janitorial and/or slight inprovements. This is useful as we don't want someone proposing a complete change in the main repo, but rather small improvements, while we are open to discuss larger mindset changes for the same topic which could land in the same org and different repo.

@ckotzbauer
Copy link
Member

I agree, I think we can elaborate a bit more about the rate of changes and their size in the last months.
"Feature complete" is a phrase, we should be a bit careful, I guess. I know we're not planning to integrate completely new or bigger features, but as there are many issues open right now which are requesting several improvements and add new ideas, I think we maybe would shock a part of the community and force to search for other solutions. WDYT?

@dholbach
Copy link
Member Author

dholbach commented Aug 5, 2024

I moved some of the directory structure bits to: kubereboot/kured#964

Signed-off-by: Daniel Holbach <daniel.holbach@gmail.com>
Copy link
Contributor

@evrardjp evrardjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I am not in favour of mentioning "flame and glory" (maintaining is not glorious or doesn't attract fame), I believe that ppl reading this will get a vibe of our humourous stances, which is good enough. Let's go.

@dholbach
Copy link
Member Author

dholbach commented Aug 7, 2024

Thanks for the reviews! I'll put some more work into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants