Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go to 1.23.4, /x/net to v0.33.0, and /x/crypto to v0.31.0 #3509

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Update Go to 1.23.4, /x/net to v0.33.0, and /x/crypto to v0.31.0 #3509

merged 3 commits into from
Dec 20, 2024

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Dec 20, 2024 •
edited
Loading

What this PR does / why we need it:

  • Update Go to 1.23.4
  • Update golang.org/x/crypto to v0.31.0 to pick up CVE fixes
  • Update golang.org/x/net to v0.33.0 to pick up CVE fixes

I disabled gosec G115 linter error because it has a lot of false positives that are not relevant to us, but that take significant amount of code to fix (and potentially an external dependency). See securego/gosec#1212 for more details

What type of PR is this?
/kind chore

Does this PR introduce a user-facing change? Then add your Release Note here:

KubeOne is now built with Go 1.23.4

Documentation:

NONE

/assign @kron4eg

@xmudrii
Update Go to 1.23.4, /x/net to v0.33.0, and /x/crypto to v0.31.0
072c9bb 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg December 20, 2024 12:27
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/chore Updating grunt tasks etc; no production code changes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Dec 20, 2024
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 20, 2024
@xmudrii
Increase resources for pull-kubeone-verify-codegen
a163c78 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
kron4eg
kron4eg approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 975fef6b00c7b6c3045b45dc51606ca3a502ec14

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
@xmudrii xmudrii marked this pull request as ready for review December 20, 2024 12:43
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 20, 2024
@xmudrii
Disable gosec G115 linter error
4c5372b 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
@xmudrii
Copy link
Member Author

xmudrii commented Dec 20, 2024

/test pull-kubeone-e2e-aws-default-install-containerd-external-v1.29

@xmudrii
Copy link
Member Author

xmudrii commented Dec 20, 2024

/cherrypick release/v1.9

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.9 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xmudrii
Copy link
Member Author

xmudrii commented Dec 20, 2024

/test pull-kubeone-e2e-aws-default-install-containerd-external-v1.29

@kron4eg
Copy link
Member

kron4eg commented Dec 20, 2024

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f550d360729fcad199a33776e0c9b4f801eb47f5

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kron4eg
Copy link
Member

kron4eg commented Dec 20, 2024

/retest

@kubermatic-bot kubermatic-bot merged commit 4e145ef into main Dec 20, 2024
13 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.10 milestone Dec 20, 2024
@kubermatic-bot kubermatic-bot deleted the dep-updates branch December 20, 2024 16:43
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #3513

In response to this:

/cherrypick release/v1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Dec 20, 2024
Merged
@xmudrii xmudrii mentioned this pull request Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.10
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @kron4eg