Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow-downgrades for dockerce and containerd #1073

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Allow-downgrades for dockerce and containerd #1073

merged 1 commit into from
Oct 15, 2021

Conversation

2000yeshu
Copy link
Contributor

@2000yeshu 2000yeshu commented Oct 14, 2021 •
edited by kron4eg
Loading

What this PR does / why we need it:
If dockerce or/and containerd is/are already present on the machine, then the setup script will not install them and throw an error if the version installed is already higher than what we require, so I have added a --allow-downgrades flag to the installation script to downgrade them to the required version and complete the script execution without the error.

Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Fixes #1049

Special notes for your reviewer:

Optional Release Note:

Allow-downgrades for docker-ce and containerd

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 14, 2021
@kubermatic-bot
Copy link
Contributor

Hi @2000yeshu. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2021
@2000yeshu
Copy link
Contributor Author

/assign @xmudrii

@kron4eg
Copy link
Member

kron4eg commented Oct 15, 2021

@2000yeshu Thank for the PR!

Please run go test ./pkg/userdata/... -update and commit the changes.

@kron4eg kron4eg assigned kron4eg and unassigned xmudrii Oct 15, 2021
@kron4eg kron4eg self-requested a review October 15, 2021 10:03
kron4eg
kron4eg requested changes Oct 15, 2021
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 15, 2021
Allow-downgrades for dockerce and containerd
c8c399c 
If dockerce or/and containerd is/are already present on the machine, then the setup script will not install them if the version installed is already higher than what we require, so I have added a allow-downgrades flag to the installation script

Signed-off-by: Yakul Garg <2000yeshu@gmail.com>
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 15, 2021
@2000yeshu
Copy link
Contributor Author

Done

kron4eg
kron4eg approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test all

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9a5eb16019891bb81f8097e35b193a87f7a3186b

@kron4eg
Copy link
Member

kron4eg commented Oct 15, 2021

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2000yeshu, kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2021
@kubermatic-bot kubermatic-bot merged commit 6764efa into kubermatic:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--allow-downgrades in /opt/bin/setup
4 participants
@2000yeshu @kubermatic-bot @kron4eg @xmudrii