-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support for ca-bundle #399
Conversation
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found few forgotten names.
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
83fa97d
to
c0b101b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: f5109822da30207a9842a8e00313408cdb92fad5
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release/v1.5 |
@kron4eg: #399 failed to apply on top of branch "release/v1.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* Fix support for ca-bundle Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Add support for custom ca-bundle in all the OSPs Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> --------- Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> Signed-off-by: Artiom Diomin <artiom@kubermatic.com>
* Fix support for ca-bundle * Add support for custom ca-bundle in all the OSPs --------- Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> Signed-off-by: Artiom Diomin <artiom@kubermatic.com> Co-authored-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
What this PR does / why we need it:
This PR fixes the
ca-bundle
flag/support in OSM. This flag is used to override the PKI certs for Kubernetes. Although in our other tools like machine-controller, KubeOne, the functionality is a bit different and this is used to override the CA certs for the host and in-code clients that communicate with external services.To clear this ambiguity, we have to split it into
kubernetes-ca-bundle
andhost-ca-bundle
flags to make it coherent and self-explanatory. The flagca-bundle
has been deprecated and made no-op.Which issue(s) this PR fixes:
Fixes #235
What type of PR is this?
/kind feature
/kind deprecation
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: