-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve DNS resolution issues for Hetzner on Ubuntu 24.04 #419
Resolve DNS resolution issues for Hetzner on Ubuntu 24.04 #419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
LGTM label has been added. Git tree hash: 024ce89ae3e527d8b1fefa29622d309e72a37621
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: moadqassem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
ef419ff
to
2e60d09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 4e683923af3d1403b55dbe57bd70f240a908e435
|
What this PR does / why we need it:
This PR aims to fix a bug that we ran into with Hetzner machines on Ubuntu 24.04. During our testing cycles for Ubuntu 24.04 support, we found out that DNS somehow stops working after some time; we first thought about removing:
For Hetzner, it has larger implications, the main one being that dual-stack networking stops working if we remove this line; it was added specifically for that in #200.
Another side-effect that we found out during testing was that even if we skip this, sometimes the DNS gets broken so early that we are unable to even fetch the provisioning configuration from the Kubernetes secret.
Hence, to resolve this, we are resorting to Cloudflare DNS as fallback in case the DNS resolution fails.
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: