Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve DNS resolution issues for Hetzner on Ubuntu 24.04 #419

Merged

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:
This PR aims to fix a bug that we ran into with Hetzner machines on Ubuntu 24.04. During our testing cycles for Ubuntu 24.04 support, we found out that DNS somehow stops working after some time; we first thought about removing:

rm /etc/netplan/50-cloud-init.yaml

For Hetzner, it has larger implications, the main one being that dual-stack networking stops working if we remove this line; it was added specifically for that in #200.

Another side-effect that we found out during testing was that even if we skip this, sometimes the DNS gets broken so early that we are unable to even fetch the provisioning configuration from the Kubernetes secret.

Hence, to resolve this, we are resorting to Cloudflare DNS as fallback in case the DNS resolution fails.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Resolve DNS resolution issues for Hetzner on Ubuntu 24.04

Documentation:

NONE

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Oct 10, 2024
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2024
Copy link
Member

@moadqassem moadqassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 024ce89ae3e527d8b1fefa29622d309e72a37621

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moadqassem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2024
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2024
Copy link
Member

@moadqassem moadqassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4e683923af3d1403b55dbe57bd70f240a908e435

@kubermatic-bot kubermatic-bot merged commit a5fa2ed into kubermatic:main Oct 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants