Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OnError event to MetaObjectLock #1585

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ public abstract class MetaObjectLock<T> : ILock
private readonly string identity;
private T metaObjCache;

/// <summary>
/// OnHttpError is called when there is a http operation error.
/// </summary>
public event Action<HttpOperationException> OnHttpError;

protected MetaObjectLock(IKubernetes client, string @namespace, string name, string identity)
{
this.client = client ?? throw new ArgumentNullException(nameof(client));
Expand Down Expand Up @@ -47,8 +52,9 @@ public async Task<bool> CreateAsync(LeaderElectionRecord record, CancellationTok
Interlocked.Exchange(ref metaObjCache, createdObj);
return true;
}
catch (HttpOperationException)
catch (HttpOperationException e)
{
OnHttpError?.Invoke(e);
// ignore
}

Expand Down Expand Up @@ -79,8 +85,9 @@ public async Task<bool> UpdateAsync(LeaderElectionRecord record, CancellationTok
Interlocked.Exchange(ref metaObjCache, replacedObj);
return true;
}
catch (HttpOperationException)
catch (HttpOperationException e)
{
OnHttpError?.Invoke(e);
// ignore
}

Expand Down
Loading