Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #233 #240

Merged
merged 2 commits into from
Apr 20, 2018
Merged

Fix issue #233 #240

merged 2 commits into from
Apr 20, 2018

Conversation

archcosmo
Copy link
Contributor

This should fix issue #233.

@brendandburns
Copy link
Contributor

LGTM, though you need to sign the CLA.

Can you add a unit test to validate this behavior so that we don't regress in the future?

Also, if you feel like it, it might be worth making a similar change in the swagger-codegen repository since that's where this code was derived from...

Thanks!

@brendandburns
Copy link
Contributor

oh, wait, nevermind about the CLA, it just turned green...

But please do add a unit test.

@Bas83
Copy link

Bas83 commented Apr 19, 2018

Just curious, why preserve the htmlSafe boolean? Is there ever a reason to create htmlSafe output?

@brendandburns
Copy link
Contributor

I think that is correct in terms of "do no harm" or "least surprise" you want to preserve whatever the settings were prior to you mucking with things...

@archcosmo
Copy link
Contributor Author

Yes, I wasn't sure where else the writer was being used and didn't want to affect anything else.
I've written a jUnit test, does it fit with the convention?

@brendandburns
Copy link
Contributor

LGTM, thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants