release 1.3.0 preparations #155
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/S
|
/assign @msau42 |
New changelog, version of image bumped to v1.3.0.
CHANGELOG-1.3.md
Outdated
|
|
||
| ## New Features | ||
|
|
||
| - Adds deployment for Kubernetes 1.17 with snapshot beta CRD ([#98](https://github.com/kubernetes-csi/csi-driver-host-path/pull/98), [@xing-yang](https://github.com/xing-yang)) |
There was a problem hiding this comment.
To clarify, the deployment is not installed as part of this. Maybe it can just say "supporting the snapshot beta feature"
There was a problem hiding this comment.
So it ended up being done differently than describe in the PR description? Let's make it very clear that the CRD needs to be installed separately. How about:
"Adds deployment for Kubernetes 1.17. Starting with this deployment, the snapshot CRD is no longer part of the driver installation and must be installed as part of the cluster."
| - The -ephemeral parameter (currently alpha) is still supported, but only needed for Kubernetes 1.15 and will be removed once Kubernetes 1.15 stops being supported. On Kubernetes 1.16, the same deployment supports normal persistent volumes and inline ephemeral volumes. ([#67](https://github.com/kubernetes-csi/csi-driver-host-path/pull/67), [@pohly](https://github.com/pohly)) | ||
|
|
||
|
|
||
| ## Bug Fixes |
There was a problem hiding this comment.
These are all minor bug fixes. I guess we can add entries for them, but then we should also make sure in future reviews that the PR description actually is something other than NONE.
CHANGELOG-1.3.md
Outdated
|
|
||
| ## Bug Fixes | ||
|
|
||
| - Set volume content source if creating volume from snapshot. ([#51](https://github.com/kubernetes-csi/csi-driver-host-path/pull/51), [@zhucan](https://github.com/zhucan)) |
There was a problem hiding this comment.
This is already included in 1.2 changelog?
There was a problem hiding this comment.
Indeed. I wonder why the release-notes tool picked it up again. Fixed.
Added some bug fixes which didn't have release notes, removed one which was picked up again by the release-notes tool, and enhanced the description of the 1.17 deployment.
|
@msau42: pushed, please have another look. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
owners: introduce aliases
What type of PR is this?
/kind feature
What this PR does / why we need it:
The existing 1.2.0 release has no deployment for Kubernetes 1.17. Time to do a release...
Special notes for your reviewer:
The tests are going to fail. We need to merge manually and then immediately create a v1.3.0 release.
Does this PR introduce a user-facing change?: